Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 1582333008: Let a minimum time interval pass (one bucket size) after initialization before reporting rates (to … (Closed)

Created:
4 years, 11 months ago by åsapersson
Modified:
4 years, 10 months ago
Reviewers:
mflodman
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Let a minimum time interval pass (one bucket size) after initialization before reporting rates (to avoid rates being based on too short time intervals). BUG=chromium:570038 Committed: https://crrev.com/799379e8c29793b9f681e61dbd1075481b77359a Cr-Commit-Position: refs/heads/master@{#11455}

Patch Set 1 #

Patch Set 2 : add unittest #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -3 lines) Patch
M webrtc/base/ratetracker.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M webrtc/base/ratetracker_unittest.cc View 1 2 chunks +9 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
åsapersson
4 years, 11 months ago (2016-01-18 08:05:53 UTC) #3
mflodman
Functionality Lg and I agree, but it would be good with a unittest for this.
4 years, 11 months ago (2016-01-27 11:57:43 UTC) #4
åsapersson
On 2016/01/27 11:57:43, mflodman wrote: > Functionality Lg and I agree, but it would be ...
4 years, 11 months ago (2016-01-27 12:31:27 UTC) #5
mflodman
lgtm
4 years, 10 months ago (2016-02-02 08:37:23 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1582333008/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1582333008/20001
4 years, 10 months ago (2016-02-02 08:46:11 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-02 09:47:06 UTC) #10
commit-bot: I haz the power
4 years, 10 months ago (2016-02-02 09:47:15 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/799379e8c29793b9f681e61dbd1075481b77359a
Cr-Commit-Position: refs/heads/master@{#11455}

Powered by Google App Engine
This is Rietveld 408576698