Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 1582323005: [rtp_rtcp] Append functionality moved from base RtcpPacket class to CompoundPacket (Closed)

Created:
4 years, 11 months ago by danilchap
Modified:
4 years, 9 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, stefan-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

[rtp_rtcp] Append functionality moved from base RtcpPacket class to CompoundPacket BUG=webrtc:5260 Committed: https://crrev.com/7a4116aa54907c687d629661ccce8d6b9e9ef8d9 Cr-Commit-Position: refs/heads/master@{#11981}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : rebase #

Patch Set 4 : rebase #

Patch Set 5 : rebase #

Patch Set 6 : rebase #

Patch Set 7 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -83 lines) Patch
M webrtc/modules/rtp_rtcp/source/rtcp_packet.h View 1 2 3 4 chunks +13 lines, -24 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet.cc View 1 2 3 3 chunks +2 lines, -20 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/compound_packet.h View 1 2 chunks +10 lines, -4 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/compound_packet.cc View 1 chunk +16 lines, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/compound_packet_unittest.cc View 1 2 3 6 chunks +20 lines, -23 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_receiver_unittest.cc View 1 2 3 4 5 6 6 chunks +21 lines, -11 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
danilchap
move done so that rtcp_sender that use Append functionality is unchanged.
4 years, 10 months ago (2016-02-11 17:41:34 UTC) #1
sprang_webrtc
lgtm +stefan as owner
4 years, 9 months ago (2016-02-29 13:21:54 UTC) #5
åsapersson
lgtm
4 years, 9 months ago (2016-03-14 13:29:21 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1582323005/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1582323005/120001
4 years, 9 months ago (2016-03-14 13:34:37 UTC) #10
commit-bot: I haz the power
Committed patchset #7 (id:120001)
4 years, 9 months ago (2016-03-14 15:19:32 UTC) #12
commit-bot: I haz the power
4 years, 9 months ago (2016-03-14 15:19:38 UTC) #14
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/7a4116aa54907c687d629661ccce8d6b9e9ef8d9
Cr-Commit-Position: refs/heads/master@{#11981}

Powered by Google App Engine
This is Rietveld 408576698