Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Unified Diff: webrtc/modules/rtp_rtcp/source/rtcp_packet/fir_unittest.cc

Issue 1581983003: [rtp_rtcp] rtcp::Fir moved into own file (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: rebase Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/rtp_rtcp/source/rtcp_packet/fir_unittest.cc
diff --git a/webrtc/modules/rtp_rtcp/source/rtcp_packet/tmmbr_unittest.cc b/webrtc/modules/rtp_rtcp/source/rtcp_packet/fir_unittest.cc
similarity index 56%
copy from webrtc/modules/rtp_rtcp/source/rtcp_packet/tmmbr_unittest.cc
copy to webrtc/modules/rtp_rtcp/source/rtcp_packet/fir_unittest.cc
index 6d71caa251652bf640deb65419cdc12f393d3651..b65a0c3f5a0e256673b492ab7e3c5f1236a23256 100644
--- a/webrtc/modules/rtp_rtcp/source/rtcp_packet/tmmbr_unittest.cc
+++ b/webrtc/modules/rtp_rtcp/source/rtcp_packet/fir_unittest.cc
@@ -8,36 +8,35 @@
* be found in the AUTHORS file in the root of the source tree.
*/
-#include "webrtc/modules/rtp_rtcp/source/rtcp_packet/tmmbr.h"
+#include "webrtc/modules/rtp_rtcp/source/rtcp_packet/fir.h"
+#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
-
-#include "webrtc/modules/rtp_rtcp/source/byte_io.h"
#include "webrtc/test/rtcp_packet_parser.h"
+using webrtc::rtcp::Fir;
using webrtc::rtcp::RawPacket;
-using webrtc::rtcp::Tmmbr;
using webrtc::test::RtcpPacketParser;
namespace webrtc {
+
const uint32_t kSenderSsrc = 0x12345678;
const uint32_t kRemoteSsrc = 0x23456789;
-TEST(RtcpPacketTest, Tmmbr) {
- Tmmbr tmmbr;
- tmmbr.From(kSenderSsrc);
- tmmbr.To(kRemoteSsrc);
- tmmbr.WithBitrateKbps(312);
- tmmbr.WithOverhead(60);
+TEST(RtcpPacketFirTest, Fir) {
+ Fir fir;
+ fir.From(kSenderSsrc);
+ fir.To(kRemoteSsrc);
+ fir.WithCommandSeqNum(123);
- rtc::scoped_ptr<RawPacket> packet(tmmbr.Build());
+ rtc::scoped_ptr<RawPacket> packet(fir.Build());
RtcpPacketParser parser;
parser.Parse(packet->Buffer(), packet->Length());
- EXPECT_EQ(1, parser.tmmbr()->num_packets());
- EXPECT_EQ(kSenderSsrc, parser.tmmbr()->Ssrc());
- EXPECT_EQ(1, parser.tmmbr_item()->num_packets());
- EXPECT_EQ(312U, parser.tmmbr_item()->BitrateKbps());
- EXPECT_EQ(60U, parser.tmmbr_item()->Overhead());
+ EXPECT_EQ(1, parser.fir()->num_packets());
+ EXPECT_EQ(kSenderSsrc, parser.fir()->Ssrc());
+ EXPECT_EQ(1, parser.fir_item()->num_packets());
+ EXPECT_EQ(kRemoteSsrc, parser.fir_item()->Ssrc());
+ EXPECT_EQ(123U, parser.fir_item()->SeqNum());
}
} // namespace webrtc
« no previous file with comments | « webrtc/modules/rtp_rtcp/source/rtcp_packet/fir.cc ('k') | webrtc/modules/rtp_rtcp/source/rtcp_packet_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698