Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1071)

Unified Diff: webrtc/modules/rtp_rtcp/source/rtcp_packet_unittest.cc

Issue 1581983003: [rtp_rtcp] rtcp::Fir moved into own file (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/rtp_rtcp/source/rtcp_packet_unittest.cc
diff --git a/webrtc/modules/rtp_rtcp/source/rtcp_packet_unittest.cc b/webrtc/modules/rtp_rtcp/source/rtcp_packet_unittest.cc
index 22f61f5cab9b6a6791cc225d2172e7847a783c84..87b803c8346a7228bb0b1e4319eccc3b7c40a25a 100644
--- a/webrtc/modules/rtp_rtcp/source/rtcp_packet_unittest.cc
+++ b/webrtc/modules/rtp_rtcp/source/rtcp_packet_unittest.cc
@@ -24,7 +24,6 @@ using ::testing::ElementsAre;
using webrtc::rtcp::App;
using webrtc::rtcp::Bye;
using webrtc::rtcp::Dlrr;
-using webrtc::rtcp::Fir;
using webrtc::rtcp::RawPacket;
using webrtc::rtcp::ReceiverReport;
using webrtc::rtcp::Remb;
@@ -288,22 +287,6 @@ TEST(RtcpPacketTest, RpsiWithMaxPictureId) {
EXPECT_EQ(kPictureId, parser.rpsi()->PictureId());
}
-TEST(RtcpPacketTest, Fir) {
- Fir fir;
- fir.From(kSenderSsrc);
- fir.To(kRemoteSsrc);
- fir.WithCommandSeqNum(123);
-
- rtc::scoped_ptr<RawPacket> packet(fir.Build());
- RtcpPacketParser parser;
- parser.Parse(packet->Buffer(), packet->Length());
- EXPECT_EQ(1, parser.fir()->num_packets());
- EXPECT_EQ(kSenderSsrc, parser.fir()->Ssrc());
- EXPECT_EQ(1, parser.fir_item()->num_packets());
- EXPECT_EQ(kRemoteSsrc, parser.fir_item()->Ssrc());
- EXPECT_EQ(123U, parser.fir_item()->SeqNum());
-}
-
TEST(RtcpPacketTest, BuildWithTooSmallBuffer) {
ReportBlock rb;
ReceiverReport rr;

Powered by Google App Engine
This is Rietveld 408576698