Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Unified Diff: webrtc/modules/rtp_rtcp/source/rtcp_packet.h

Issue 1581983003: [rtp_rtcp] rtcp::Fir moved into own file (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/rtp_rtcp/source/rtcp_packet.h
diff --git a/webrtc/modules/rtp_rtcp/source/rtcp_packet.h b/webrtc/modules/rtp_rtcp/source/rtcp_packet.h
index 01c97c38badf42436d608e2b058a797363370325..0d3cac2580126183c4792cd3515a50d98c8e73ec 100644
--- a/webrtc/modules/rtp_rtcp/source/rtcp_packet.h
+++ b/webrtc/modules/rtp_rtcp/source/rtcp_packet.h
@@ -306,53 +306,6 @@ class Rpsi : public RtcpPacket {
RTC_DISALLOW_COPY_AND_ASSIGN(Rpsi);
};
-// Full intra request (FIR) (RFC 5104).
-//
-// FCI:
-//
-// 0 1 2 3
-// 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1
-// +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
-// | SSRC |
-// +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
-// | Seq nr. | Reserved |
-// +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
-
-class Fir : public RtcpPacket {
- public:
- Fir() : RtcpPacket() {
- memset(&fir_, 0, sizeof(fir_));
- memset(&fir_item_, 0, sizeof(fir_item_));
- }
-
- virtual ~Fir() {}
-
- void From(uint32_t ssrc) {
- fir_.SenderSSRC = ssrc;
- }
- void To(uint32_t ssrc) {
- fir_item_.SSRC = ssrc;
- }
- void WithCommandSeqNum(uint8_t seq_num) {
- fir_item_.CommandSequenceNumber = seq_num;
- }
-
- protected:
- bool Create(uint8_t* packet,
- size_t* index,
- size_t max_length,
- RtcpPacket::PacketReadyCallback* callback) const override;
-
- private:
- size_t BlockLength() const {
- const size_t kFciLength = 8;
- return kCommonFbFmtLength + kFciLength;
- }
-
- RTCPUtility::RTCPPacketPSFBFIR fir_;
- RTCPUtility::RTCPPacketPSFBFIRItem fir_item_;
-};
-
// Receiver Estimated Max Bitrate (REMB) (draft-alvestrand-rmcat-remb).
//
// 0 1 2 3

Powered by Google App Engine
This is Rietveld 408576698