Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 1581983003: [rtp_rtcp] rtcp::Fir moved into own file (Closed)

Created:
4 years, 11 months ago by danilchap
Modified:
4 years, 11 months ago
Reviewers:
åsapersson
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, stefan-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+123 lines, -148 lines) Patch
M webrtc/modules/modules.gyp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/rtp_rtcp/BUILD.gn View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/modules/rtp_rtcp/rtp_rtcp.gypi View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet.h View 1 2 1 chunk +0 lines, -47 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet.cc View 1 2 5 chunks +0 lines, -46 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/compound_packet_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
A + webrtc/modules/rtp_rtcp/source/rtcp_packet/fir.h View 1 2 2 chunks +22 lines, -22 lines 0 comments Download
A webrtc/modules/rtp_rtcp/source/rtcp_packet/fir.cc View 1 chunk +78 lines, -0 lines 0 comments Download
A + webrtc/modules/rtp_rtcp/source/rtcp_packet/fir_unittest.cc View 1 1 chunk +15 lines, -16 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet_unittest.cc View 1 2 2 chunks +0 lines, -17 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_receiver_unittest.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_sender.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
åsapersson
lgtm https://codereview.webrtc.org/1581983003/diff/1/webrtc/modules/rtp_rtcp/source/rtcp_packet/fir_unittest.cc File webrtc/modules/rtp_rtcp/source/rtcp_packet/fir_unittest.cc (right): https://codereview.webrtc.org/1581983003/diff/1/webrtc/modules/rtp_rtcp/source/rtcp_packet/fir_unittest.cc#newcode26 webrtc/modules/rtp_rtcp/source/rtcp_packet/fir_unittest.cc:26: TEST(RtcpPacketTest, Fir) { s/RtcpPacketTest/RtcpPacketFirTest
4 years, 11 months ago (2016-01-15 10:48:05 UTC) #1
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/5679da12918b18e19d97acaaee5bbe6e1acf8491 Cr-Commit-Position: refs/heads/master@{#11269}
4 years, 11 months ago (2016-01-15 12:20:04 UTC) #4
danilchap
4 years, 11 months ago (2016-01-15 12:20:05 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
5679da12918b18e19d97acaaee5bbe6e1acf8491 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698