Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 1581903002: Put options as the argument of the PeerConnectionFactory constructor (Closed)

Created:
4 years, 11 months ago by honghaiz3
Modified:
4 years, 11 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Put options as the argument of the java PeerConnectionFactory constructor. BUG= Committed: https://crrev.com/67b1e1ab0b8c88523b42836a3fab3b1504721406 Cr-Commit-Position: refs/heads/master@{#11257}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -47 lines) Patch
M talk/app/webrtc/java/jni/peerconnection_jni.cc View 4 chunks +47 lines, -36 lines 0 comments Download
M talk/app/webrtc/java/src/org/webrtc/PeerConnectionFactory.java View 4 chunks +9 lines, -2 lines 0 comments Download
M talk/app/webrtc/java/testcommon/src/org/webrtc/PeerConnectionTest.java View 2 chunks +5 lines, -7 lines 0 comments Download
M webrtc/examples/androidapp/src/org/appspot/apprtc/PeerConnectionClient.java View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 20 (10 generated)
honghaiz3
4 years, 11 months ago (2016-01-13 17:56:28 UTC) #4
pthatcher1
lgtm
4 years, 11 months ago (2016-01-14 00:12:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1581903002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1581903002/20001
4 years, 11 months ago (2016-01-14 00:17:09 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/2839)
4 years, 11 months ago (2016-01-14 01:28:34 UTC) #9
honghaiz3
4 years, 11 months ago (2016-01-14 03:47:14 UTC) #11
honghaiz3
Zeke, Can you take a look at the CL? Seem that only you and Alex ...
4 years, 11 months ago (2016-01-14 21:27:45 UTC) #13
AlexG
lgtm
4 years, 11 months ago (2016-01-14 22:26:40 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1581903002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1581903002/20001
4 years, 11 months ago (2016-01-14 22:44:38 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 11 months ago (2016-01-14 22:45:42 UTC) #18
commit-bot: I haz the power
4 years, 11 months ago (2016-01-14 22:45:50 UTC) #20
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/67b1e1ab0b8c88523b42836a3fab3b1504721406
Cr-Commit-Position: refs/heads/master@{#11257}

Powered by Google App Engine
This is Rietveld 408576698