Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1581803004:
Roll chromium_revision 346fea9..099be58 (369082:369139) (Closed)
|
Created:
4 years, 11 months ago by kjellander_webrtc Modified:
4 years, 11 months ago Reviewers:
pbos-webrtc CC:
webrtc-reviews_webrtc.org, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc Base URL:
https://chromium.googlesource.com/external/webrtc@master Target Ref:
refs/pending/heads/master Project:
webrtc Visibility:
Public. |
DescriptionRoll chromium_revision 346fea9..099be58 (369082:369139)
Change log: https://chromium.googlesource.com/chromium/src/+log/346fea9..099be58
Full diff: https://chromium.googlesource.com/chromium/src/+/346fea9..099be58
No dependencies changed.
No update to Clang.
TBR=
NOTRY=True
Committed: https://crrev.com/09d944f82db00686dc9f364628f906d3cc106707
Cr-Commit-Position: refs/heads/master@{#11238}
Patch Set 1 #Messages
Total messages: 16 (7 generated)
The CQ bit was checked by kjellander@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1581803004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1581803004/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_tsan2 on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_tsan2/builds/9170)
kjellander@webrtc.org changed reviewers: + pbos@webrtc.org
pbos, what to do with this? Disable the test for TSan?
On 2016/01/13 15:32:34, kjellander (webrtc) wrote: > pbos, what to do with this? Disable the test for TSan? Nothing tsan specific, I think this is https://bugs.chromium.org/p/webrtc/issues/detail?id=4963 or so, which really isn't only drmem/memcheck
On 2016/01/13 15:32:34, kjellander (webrtc) wrote: > pbos, what to do with this? Disable the test for TSan? Ah, it's unrelated. Failed on the bot previously here: https://build.chromium.org/p/tryserver.webrtc/builders/linux_tsan2/builds/917... I'll disable and file a bug.
Description was changed from ========== Roll chromium_revision 346fea9..099be58 (369082:369139) Change log: https://chromium.googlesource.com/chromium/src/+log/346fea9..099be58 Full diff: https://chromium.googlesource.com/chromium/src/+/346fea9..099be58 No dependencies changed. No update to Clang. TBR= ========== to ========== Roll chromium_revision 346fea9..099be58 (369082:369139) Change log: https://chromium.googlesource.com/chromium/src/+log/346fea9..099be58 Full diff: https://chromium.googlesource.com/chromium/src/+/346fea9..099be58 No dependencies changed. No update to Clang. TBR= NOTRY=True ==========
On 2016/01/13 15:34:21, kjellander (webrtc) wrote: > On 2016/01/13 15:32:34, kjellander (webrtc) wrote: > > pbos, what to do with this? Disable the test for TSan? > > Ah, it's unrelated. Failed on the bot previously here: > https://build.chromium.org/p/tryserver.webrtc/builders/linux_tsan2/builds/917... > I'll disable and file a bug. I see, I'll point at webtc:4963 then. See https://codereview.webrtc.org/1577233005/
The CQ bit was checked by kjellander@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1581803004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1581803004/1
Message was sent while issue was closed.
Description was changed from ========== Roll chromium_revision 346fea9..099be58 (369082:369139) Change log: https://chromium.googlesource.com/chromium/src/+log/346fea9..099be58 Full diff: https://chromium.googlesource.com/chromium/src/+/346fea9..099be58 No dependencies changed. No update to Clang. TBR= NOTRY=True ========== to ========== Roll chromium_revision 346fea9..099be58 (369082:369139) Change log: https://chromium.googlesource.com/chromium/src/+log/346fea9..099be58 Full diff: https://chromium.googlesource.com/chromium/src/+/346fea9..099be58 No dependencies changed. No update to Clang. TBR= NOTRY=True ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Roll chromium_revision 346fea9..099be58 (369082:369139) Change log: https://chromium.googlesource.com/chromium/src/+log/346fea9..099be58 Full diff: https://chromium.googlesource.com/chromium/src/+/346fea9..099be58 No dependencies changed. No update to Clang. TBR= NOTRY=True ========== to ========== Roll chromium_revision 346fea9..099be58 (369082:369139) Change log: https://chromium.googlesource.com/chromium/src/+log/346fea9..099be58 Full diff: https://chromium.googlesource.com/chromium/src/+/346fea9..099be58 No dependencies changed. No update to Clang. TBR= NOTRY=True Committed: https://crrev.com/09d944f82db00686dc9f364628f906d3cc106707 Cr-Commit-Position: refs/heads/master@{#11238} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/09d944f82db00686dc9f364628f906d3cc106707 Cr-Commit-Position: refs/heads/master@{#11238} |
