Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(532)

Issue 1581573003: Remove tools/refactoring. (Closed)

Created:
4 years, 11 months ago by pbos-webrtc
Modified:
4 years, 11 months ago
Reviewers:
phoglund
CC:
webrtc-reviews_webrtc.org, terelius
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove tools/refactoring. No longer used, references old GIPS types variable names and confuses team members which think this code could be used/still useful. BUG= R=phoglund@webrtc.org Committed: https://crrev.com/6183de6da0b6a6772b4aafb9a1c49f2dc856b6ea Cr-Commit-Position: refs/heads/master@{#11219}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1662 lines) Patch
D tools/refactoring/addfileheader.py View 1 chunk +0 lines, -163 lines 0 comments Download
D tools/refactoring/filemanagement.py View 1 chunk +0 lines, -72 lines 0 comments Download
D tools/refactoring/fixincludeguards.py View 1 chunk +0 lines, -145 lines 0 comments Download
D tools/refactoring/fixnames.py View 1 chunk +0 lines, -387 lines 0 comments Download
D tools/refactoring/integratefiles.py View 1 chunk +0 lines, -100 lines 0 comments Download
D tools/refactoring/p4commands.py View 1 chunk +0 lines, -31 lines 0 comments Download
D tools/refactoring/removetrace.py View 1 chunk +0 lines, -161 lines 0 comments Download
D tools/refactoring/stringmanipulation.py View 1 chunk +0 lines, -303 lines 0 comments Download
D tools/refactoring/trim.py View 1 chunk +0 lines, -29 lines 0 comments Download
D tools/refactoring/trimall.py View 1 chunk +0 lines, -59 lines 0 comments Download
D tools/refactoring/webrtc_reformat.py View 1 chunk +0 lines, -212 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
pbos-webrtc
I don't think any of these are in use and haven't heard of anyone using ...
4 years, 11 months ago (2016-01-12 11:07:22 UTC) #1
phoglund
They were used years ago (the only I know of is webrtc_reformat, which reformats from ...
4 years, 11 months ago (2016-01-12 12:06:27 UTC) #2
pbos-webrtc
Committed patchset #1 (id:1) manually as 6183de6da0b6a6772b4aafb9a1c49f2dc856b6ea (presubmit successful).
4 years, 11 months ago (2016-01-12 12:41:17 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/6183de6da0b6a6772b4aafb9a1c49f2dc856b6ea Cr-Commit-Position: refs/heads/master@{#11219}
4 years, 11 months ago (2016-01-12 12:41:17 UTC) #6
kjellander_webrtc
On 2016/01/12 12:41:17, commit-bot: I haz the power wrote: > Patchset 1 (id:??) landed as ...
4 years, 11 months ago (2016-01-20 15:52:40 UTC) #7
pbos-webrtc
On 2016/01/20 15:52:40, kjellander (webrtc) wrote: > On 2016/01/12 12:41:17, commit-bot: I haz the power ...
4 years, 11 months ago (2016-01-20 15:53:35 UTC) #8
kjellander_webrtc
4 years, 11 months ago (2016-01-20 16:10:01 UTC) #9
Message was sent while issue was closed.
On 2016/01/20 15:52:40, kjellander (webrtc) wrote:
> On 2016/01/12 12:41:17, commit-bot: I haz the power wrote:
> > Patchset 1 (id:??) landed as
> > https://crrev.com/6183de6da0b6a6772b4aafb9a1c49f2dc856b6ea
> > Cr-Commit-Position: refs/heads/master@{#11219}
> 
> I'm using fixincludeguards.py when moving code around and find it very useful.
I
> think some of these may still be useful considering we still have a lot of
work
> to do. Maybe put a README in here instead? Or remove only the ones that are
> obviously of no use?

Given second thought, I tried to use the script now again and now it simply
didn't work, so feel free to ignore my comment above. I guess we need better
scripts if they are going to be useful.

Powered by Google App Engine
This is Rietveld 408576698