Support REMB in combination with send-side BWE.

Support REMB in combination with send-side BWE.

BUG=webrtc:4173
Committed: https://crrev.com/32f81542c20f86fb855bf37ba030e523d1016939
Cr-Commit-Position: refs/heads/master@{#11322}

[stefan-webrtc, 2016-01-15 12:34:42]

stefan@webrtc.org changed reviewers:
+ sprang@webrtc.org

[stefan-webrtc, 2016-01-15 12:52:20]

The CQ bit was checked by stefan@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-15 12:52:27]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1581113006/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1581113006/1

[sprang, 2016-01-15 13:36:27]

sprang@google.com changed reviewers:
+ sprang@google.com

[sprang, 2016-01-15 13:36:27]

lg, just a question..

https://codereview.webrtc.org/1581113006/diff/1/webrtc/video/end_to_end_tests.cc
File webrtc/video/end_to_end_tests.cc (right):

https://codereview.webrtc.org/1581113006/diff/1/webrtc/video/end_to_end_tests...
webrtc/video/end_to_end_tests.cc:1825: (*receive_configs)[0].rtp.remb = false;
Why do we set this to false? Just to explicitly indicate "regular" remb
shouldn't be sent?

https://codereview.webrtc.org/1581113006/diff/1/webrtc/video/end_to_end_tests...
webrtc/video/end_to_end_tests.cc:1849: if (sender_call_) {
A short description of what this test case does would perhaps be in place.

[commit-bot: I haz the power, 2016-01-15 13:52:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-15 13:52:57]

Dry run: This issue passed the CQ dry run.

[stefan-webrtc, 2016-01-20 12:50:14]

Added comment.

[stefan-webrtc, 2016-01-20 12:50:28]

https://codereview.webrtc.org/1581113006/diff/1/webrtc/video/end_to_end_tests.cc
File webrtc/video/end_to_end_tests.cc (right):

https://codereview.webrtc.org/1581113006/diff/1/webrtc/video/end_to_end_tests...
webrtc/video/end_to_end_tests.cc:1825: (*receive_configs)[0].rtp.remb = false;
On 2016/01/15 13:36:27, sprang wrote:
> Why do we set this to false? Just to explicitly indicate "regular" remb
> shouldn't be sent?

Yes. It should however not have any effect.

https://codereview.webrtc.org/1581113006/diff/1/webrtc/video/end_to_end_tests...
webrtc/video/end_to_end_tests.cc:1849: if (sender_call_) {
On 2016/01/15 13:36:27, sprang wrote:
> A short description of what this test case does would perhaps be in place.

Done.

[sprang_webrtc, 2016-01-20 12:58:43]

lgtm

[stefan-webrtc, 2016-01-20 13:12:13]

The CQ bit was checked by stefan@webrtc.org

[commit-bot: I haz the power, 2016-01-20 13:12:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1581113006/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1581113006/20001

[commit-bot: I haz the power, 2016-01-20 15:14:02]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-01-20 15:14:09]

Description was changed from

==========
Support REMB in combination with send-side BWE.

BUG=webrtc:4173
==========

to

==========
Support REMB in combination with send-side BWE.

BUG=webrtc:4173

Committed: https://crrev.com/32f81542c20f86fb855bf37ba030e523d1016939
Cr-Commit-Position: refs/heads/master@{#11322}
==========

[commit-bot: I haz the power, 2016-01-20 15:14:10]

Patchset 2 (id:??) landed as
https://crrev.com/32f81542c20f86fb855bf37ba030e523d1016939
Cr-Commit-Position: refs/heads/master@{#11322}