Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(661)

Unified Diff: webrtc/modules/rtp_rtcp/source/rtcp_sender.cc

Issue 1579213005: [rtp_rtcp] rtcp::Xr moved into own file and renamed to ExtendedReports on the way (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/modules/rtp_rtcp/source/rtcp_receiver_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/modules/rtp_rtcp/source/rtcp_sender.cc
diff --git a/webrtc/modules/rtp_rtcp/source/rtcp_sender.cc b/webrtc/modules/rtp_rtcp/source/rtcp_sender.cc
index 69b0ae1a2ffe969ece7aa49d218163b281fe034e..9ff50fc81130623e94f6224da79d8850c00b24df 100644
--- a/webrtc/modules/rtp_rtcp/source/rtcp_sender.cc
+++ b/webrtc/modules/rtp_rtcp/source/rtcp_sender.cc
@@ -25,6 +25,7 @@
#include "webrtc/modules/rtp_rtcp/source/rtcp_packet/app.h"
#include "webrtc/modules/rtp_rtcp/source/rtcp_packet/bye.h"
#include "webrtc/modules/rtp_rtcp/source/rtcp_packet/compound_packet.h"
+#include "webrtc/modules/rtp_rtcp/source/rtcp_packet/extended_reports.h"
#include "webrtc/modules/rtp_rtcp/source/rtcp_packet/fir.h"
#include "webrtc/modules/rtp_rtcp/source/rtcp_packet/nack.h"
#include "webrtc/modules/rtp_rtcp/source/rtcp_packet/pli.h"
@@ -742,7 +743,7 @@ rtc::scoped_ptr<rtcp::RtcpPacket> RTCPSender::BuildReceiverReferenceTime(
RTCPUtility::MidNtp(ctx.ntp_sec_, ctx.ntp_frac_),
Clock::NtpToMs(ctx.ntp_sec_, ctx.ntp_frac_)));
- rtcp::Xr* xr = new rtcp::Xr();
+ rtcp::ExtendedReports* xr = new rtcp::ExtendedReports();
xr->From(ssrc_);
rtcp::Rrtr rrtr;
@@ -752,12 +753,12 @@ rtc::scoped_ptr<rtcp::RtcpPacket> RTCPSender::BuildReceiverReferenceTime(
// TODO(sprang): Merge XR report sending to contain all of RRTR, DLRR, VOIP?
- return rtc::scoped_ptr<rtcp::Xr>(xr);
+ return rtc::scoped_ptr<rtcp::RtcpPacket>(xr);
}
rtc::scoped_ptr<rtcp::RtcpPacket> RTCPSender::BuildDlrr(
const RtcpContext& ctx) {
- rtcp::Xr* xr = new rtcp::Xr();
+ rtcp::ExtendedReports* xr = new rtcp::ExtendedReports();
xr->From(ssrc_);
rtcp::Dlrr dlrr;
@@ -766,13 +767,13 @@ rtc::scoped_ptr<rtcp::RtcpPacket> RTCPSender::BuildDlrr(
xr->WithDlrr(&dlrr);
- return rtc::scoped_ptr<rtcp::Xr>(xr);
+ return rtc::scoped_ptr<rtcp::RtcpPacket>(xr);
}
// TODO(sprang): Add a unit test for this, or remove if the code isn't used.
rtc::scoped_ptr<rtcp::RtcpPacket> RTCPSender::BuildVoIPMetric(
const RtcpContext& context) {
- rtcp::Xr* xr = new rtcp::Xr();
+ rtcp::ExtendedReports* xr = new rtcp::ExtendedReports();
xr->From(ssrc_);
rtcp::VoipMetric voip;
@@ -781,7 +782,7 @@ rtc::scoped_ptr<rtcp::RtcpPacket> RTCPSender::BuildVoIPMetric(
xr->WithVoipMetric(&voip);
- return rtc::scoped_ptr<rtcp::Xr>(xr);
+ return rtc::scoped_ptr<rtcp::RtcpPacket>(xr);
}
int32_t RTCPSender::SendRTCP(const FeedbackState& feedback_state,
« no previous file with comments | « webrtc/modules/rtp_rtcp/source/rtcp_receiver_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698