Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 1579213005: [rtp_rtcp] rtcp::Xr moved into own file and renamed to ExtendedReports on the way (Closed)

Created:
4 years, 11 months ago by danilchap
Modified:
4 years, 11 months ago
Reviewers:
åsapersson
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, stefan-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : rebase #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+486 lines, -434 lines) Patch
M webrtc/modules/modules.gyp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/rtp_rtcp/BUILD.gn View 1 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/modules/rtp_rtcp/rtp_rtcp.gypi View 1 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet.h View 1 2 chunks +0 lines, -68 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet.cc View 1 4 chunks +0 lines, -91 lines 0 comments Download
A webrtc/modules/rtp_rtcp/source/rtcp_packet/extended_reports.h View 1 chunk +78 lines, -0 lines 0 comments Download
A webrtc/modules/rtp_rtcp/source/rtcp_packet/extended_reports.cc View 1 chunk +111 lines, -0 lines 0 comments Download
A webrtc/modules/rtp_rtcp/source/rtcp_packet/extended_reports_unittest.cc View 1 2 1 chunk +264 lines, -0 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet_unittest.cc View 1 2 chunks +0 lines, -249 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_receiver_unittest.cc View 1 18 chunks +21 lines, -20 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_sender.cc View 1 5 chunks +7 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
danilchap
4 years, 11 months ago (2016-01-13 11:58:13 UTC) #3
åsapersson
lgtm https://codereview.webrtc.org/1579213005/diff/1/webrtc/modules/rtp_rtcp/source/rtcp_packet/extended_reports_unittest.cc File webrtc/modules/rtp_rtcp/source/rtcp_packet/extended_reports_unittest.cc (right): https://codereview.webrtc.org/1579213005/diff/1/webrtc/modules/rtp_rtcp/source/rtcp_packet/extended_reports_unittest.cc#newcode26 webrtc/modules/rtp_rtcp/source/rtcp_packet/extended_reports_unittest.cc:26: TEST(RtcpPacketTest, ExtendedReportsWithNoReportBlocks) { rename to RtcpPacketExtendedReportsTest.WithNoReportBlocks? https://codereview.webrtc.org/1579213005/diff/1/webrtc/modules/rtp_rtcp/source/rtcp_packet/extended_reports_unittest.cc#newcode37 webrtc/modules/rtp_rtcp/source/rtcp_packet/extended_reports_unittest.cc:37: ...
4 years, 11 months ago (2016-01-15 11:10:30 UTC) #4
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/256e5b23f84f2185b6950a9915c7233345441644 Cr-Commit-Position: refs/heads/master@{#11271}
4 years, 11 months ago (2016-01-15 13:16:42 UTC) #6
danilchap
4 years, 11 months ago (2016-01-15 13:16:45 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
256e5b23f84f2185b6950a9915c7233345441644 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698