Make :rtc_base_approved a public dep of :rtc_base.

Make :rtc_base_approved a public dep of :rtc_base.

It looks to me like targets :rtc_base_approved is logically a subset of
:rtc_base, and so any targets depending on :rtc_base expect to also get
access to the headers in :rtc_base_approved.

Thus I think it's appropriate for :rtc_base to have :rtc_base_approved in
public_deps, so that `gn check` will permit this without clients having to
explicitly depend on both.

NOTRY=True

Committed: https://crrev.com/5584bf4c4da20e9d5ed6f0e86352791885062f9b
Cr-Commit-Position: refs/heads/master@{#11227}

[jbroman, 2016-01-11 19:51:12]

jbroman@chromium.org changed reviewers:
+ henrikg@webrtc.org

[jbroman, 2016-01-11 19:51:13]

Chromium's content/renderer/ uses headers from, and depends on,
//third_party/webrtc/base:rtc_base.

It also uses headers from :rtc_base_approved, which works fine because
:rtc_base depends on :rtc_base_approved, but if that's the expected
behaviour then this dependency should be public (so that this passes
`gn check`).

Otherwise, the Chromium targets will have to depend on both :rtc_base and
:rtc_base_approved.

(It looks like it's intended for only :rtc_base_approved headers to be
used in Chromium, but if so, that does not seem to be the case in practice.)

R=henrikg@webrtc.org for review
CC=brettw@chromium.org FYI

[brettw, 2016-01-11 20:23:38]

brettw@chromium.org changed reviewers:
+ brettw@chromium.org

[brettw, 2016-01-11 20:23:38]

lgtm

[Henrik Grunell WebRTC, 2016-01-12 08:31:18]

Description was changed from

==========
GN: Make :rtc_base_approved a public dep of :rtc_base.

It looks to me like targets :rtc_base_approved is logically a subset of
:rtc_base, and so any targets depending on :rtc_base expect to also get
access to the headers in :rtc_base_approved.

Thus I think it's appropriate for :rtc_base to have :rtc_base_approved in
public_deps, so that `gn check` will permit this without clients having to
explicitly depend on both.
==========

to

==========
GN: Make :rtc_base_approved a public dep of :rtc_base.

It looks to me like targets :rtc_base_approved is logically a subset of
:rtc_base, and so any targets depending on :rtc_base expect to also get
access to the headers in :rtc_base_approved.

Thus I think it's appropriate for :rtc_base to have :rtc_base_approved in
public_deps, so that `gn check` will permit this without clients having to
explicitly depend on both.
==========

[Henrik Grunell WebRTC, 2016-01-12 08:31:18]

henrikg@webrtc.org changed reviewers:
+ kjellander@webrtc.org

[Henrik Grunell WebRTC, 2016-01-12 08:32:53]

I'm not very familiar with gn yet. It lgtm though I'm adding kjellander@ to take
a look as well.

[kjellander_webrtc, 2016-01-12 09:07:15]

On 2016/01/12 08:32:53, Henrik Grunell (webrtc) wrote:
> I'm not very familiar with gn yet. It lgtm though I'm adding kjellander@ to
take
> a look as well.

Sounds like a good idea, but can you add a export_dependent_settings entry for
the webrtc/base/base.gyp file as well? That way we maintain our 1:1 mapping
between GYP and GN.

[jbroman, 2016-01-12 16:22:52]

On 2016/01/12 at 09:07:15, kjellander wrote:
> On 2016/01/12 08:32:53, Henrik Grunell (webrtc) wrote:
> > I'm not very familiar with gn yet. It lgtm though I'm adding kjellander@ to
take
> > a look as well.
> 
> Sounds like a good idea, but can you add a export_dependent_settings entry for
the webrtc/base/base.gyp file as well? That way we maintain our 1:1 mapping
between GYP and GN.

Done.

[jbroman, 2016-01-12 16:26:49]

The CQ bit was checked by jbroman@chromium.org

[jbroman, 2016-01-12 16:26:49]

The patchset sent to the CQ was uploaded after l-g-t-m from henrikg@webrtc.org,
brettw@chromium.org
Link to the patchset: https://codereview.chromium.org/1578833002/#ps20001
(title: "export_dependent_settings in base.gyp")

[commit-bot: I haz the power, 2016-01-12 16:26:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1578833002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1578833002/20001

[kjellander_webrtc, 2016-01-12 16:28:52]

On 2016/01/12 16:26:54, commit-bot: I haz the power wrote:
> CQ is trying da patch. Follow status at
>  https://chromium-cq-status.appspot.com/patch-status/1578833002/20001
> View timeline at
>  https://chromium-cq-status.appspot.com/patch-timeline/1578833002/20001

lgtm


I don't know why your CL e-mails are making the URL
https://codereview.chromium.org/1578833002/ (it should be
https://codereview.webrtc.org/1578833002/). I've seen this before but I don't
remember what caused it.
It's no big deal since it's the same Rietveld instance, but anyway.

Can you update the CL description since this is no longer a GN-only change?

[jbroman, 2016-01-12 16:31:13]

Description was changed from

==========
GN: Make :rtc_base_approved a public dep of :rtc_base.

It looks to me like targets :rtc_base_approved is logically a subset of
:rtc_base, and so any targets depending on :rtc_base expect to also get
access to the headers in :rtc_base_approved.

Thus I think it's appropriate for :rtc_base to have :rtc_base_approved in
public_deps, so that `gn check` will permit this without clients having to
explicitly depend on both.
==========

to

==========
Make :rtc_base_approved a public dep of :rtc_base.

It looks to me like targets :rtc_base_approved is logically a subset of
:rtc_base, and so any targets depending on :rtc_base expect to also get
access to the headers in :rtc_base_approved.

Thus I think it's appropriate for :rtc_base to have :rtc_base_approved in
public_deps, so that `gn check` will permit this without clients having to
explicitly depend on both.
==========

[jbroman, 2016-01-12 16:31:56]

On 2016/01/12 at 16:28:52, kjellander wrote:
> On 2016/01/12 16:26:54, commit-bot: I haz the power wrote:
> > CQ is trying da patch. Follow status at
> >  https://chromium-cq-status.appspot.com/patch-status/1578833002/20001
> > View timeline at
> >  https://chromium-cq-status.appspot.com/patch-timeline/1578833002/20001
> 
> lgtm
> 
> 
> I don't know why your CL e-mails are making the URL
https://codereview.chromium.org/1578833002/ (it should be
https://codereview.webrtc.org/1578833002/). I've seen this before but I don't
remember what caused it.
> It's no big deal since it's the same Rietveld instance, but anyway.

Because in this case I clicked through to the CL from the Rietveld "My Issues"
page on codereview.chromium.org, rather than clicking from the email to
codereview.webrtc.org.

> Can you update the CL description since this is no longer a GN-only change?

Done.

[commit-bot: I haz the power, 2016-01-12 17:42:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-12 17:42:15]

Try jobs failed on following builders:
  android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  win_baremetal on tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[kjellander_webrtc, 2016-01-12 17:44:16]

Description was changed from

==========
Make :rtc_base_approved a public dep of :rtc_base.

It looks to me like targets :rtc_base_approved is logically a subset of
:rtc_base, and so any targets depending on :rtc_base expect to also get
access to the headers in :rtc_base_approved.

Thus I think it's appropriate for :rtc_base to have :rtc_base_approved in
public_deps, so that `gn check` will permit this without clients having to
explicitly depend on both.
==========

to

==========
Make :rtc_base_approved a public dep of :rtc_base.

It looks to me like targets :rtc_base_approved is logically a subset of
:rtc_base, and so any targets depending on :rtc_base expect to also get
access to the headers in :rtc_base_approved.

Thus I think it's appropriate for :rtc_base to have :rtc_base_approved in
public_deps, so that `gn check` will permit this without clients having to
explicitly depend on both.

NOTRY=True
==========

[kjellander_webrtc, 2016-01-12 17:45:15]

On 2016/01/12 17:42:15, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
>   win_baremetal on tryserver.webrtc (JOB_TIMED_OUT, no build URL)

Unfortunately we have a long queue on the trybots now. I added NOTRY=True for
this CL so we can land without them. The remaining ones won't catch anything the
green ones could have missed anyway in this case.

[kjellander_webrtc, 2016-01-12 17:45:28]

The CQ bit was checked by kjellander@webrtc.org

[commit-bot: I haz the power, 2016-01-12 17:45:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1578833002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1578833002/20001

[commit-bot: I haz the power, 2016-01-12 17:46:58]

Description was changed from

==========
Make :rtc_base_approved a public dep of :rtc_base.

It looks to me like targets :rtc_base_approved is logically a subset of
:rtc_base, and so any targets depending on :rtc_base expect to also get
access to the headers in :rtc_base_approved.

Thus I think it's appropriate for :rtc_base to have :rtc_base_approved in
public_deps, so that `gn check` will permit this without clients having to
explicitly depend on both.

NOTRY=True
==========

to

==========
Make :rtc_base_approved a public dep of :rtc_base.

It looks to me like targets :rtc_base_approved is logically a subset of
:rtc_base, and so any targets depending on :rtc_base expect to also get
access to the headers in :rtc_base_approved.

Thus I think it's appropriate for :rtc_base to have :rtc_base_approved in
public_deps, so that `gn check` will permit this without clients having to
explicitly depend on both.

NOTRY=True
==========

[commit-bot: I haz the power, 2016-01-12 17:46:59]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-01-12 17:47:04]

Description was changed from

==========
Make :rtc_base_approved a public dep of :rtc_base.

It looks to me like targets :rtc_base_approved is logically a subset of
:rtc_base, and so any targets depending on :rtc_base expect to also get
access to the headers in :rtc_base_approved.

Thus I think it's appropriate for :rtc_base to have :rtc_base_approved in
public_deps, so that `gn check` will permit this without clients having to
explicitly depend on both.

NOTRY=True
==========

to

==========
Make :rtc_base_approved a public dep of :rtc_base.

It looks to me like targets :rtc_base_approved is logically a subset of
:rtc_base, and so any targets depending on :rtc_base expect to also get
access to the headers in :rtc_base_approved.

Thus I think it's appropriate for :rtc_base to have :rtc_base_approved in
public_deps, so that `gn check` will permit this without clients having to
explicitly depend on both.

NOTRY=True

Committed: https://crrev.com/5584bf4c4da20e9d5ed6f0e86352791885062f9b
Cr-Commit-Position: refs/heads/master@{#11227}
==========

[commit-bot: I haz the power, 2016-01-12 17:47:04]

Patchset 2 (id:??) landed as
https://crrev.com/5584bf4c4da20e9d5ed6f0e86352791885062f9b
Cr-Commit-Position: refs/heads/master@{#11227}