[rtp_rtcp] rtcp::Tmmbn moved into own file

[rtp_rtcp] rtcp::Tmmbn moved into own file
explicetly unchanged.

BUG=webrtc:5260
R=åsapersson

Committed: https://crrev.com/ef3d805f6e50bc488f8e4e9e353068b78c73d17f
Cr-Commit-Position: refs/heads/master@{#11201}

[åsapersson, 2016-01-11 09:56:10]

lgtm

[danilchap, 2016-01-11 10:36:21]

The CQ bit was checked by danilchap@webrtc.org

[commit-bot: I haz the power, 2016-01-11 10:36:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1578713002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1578713002/1

[commit-bot: I haz the power, 2016-01-11 11:31:12]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-01-11 11:31:25]

Description was changed from

==========
[rtp_rtcp] rtcp::Tmmbn moved into own file
explicetly unchanged.

BUG=webrtc:5260
R=åsapersson
==========

to

==========
[rtp_rtcp] rtcp::Tmmbn moved into own file
explicetly unchanged.

BUG=webrtc:5260
R=åsapersson

Committed: https://crrev.com/ef3d805f6e50bc488f8e4e9e353068b78c73d17f
Cr-Commit-Position: refs/heads/master@{#11201}
==========

[commit-bot: I haz the power, 2016-01-11 11:31:25]

Patchset 1 (id:??) landed as
https://crrev.com/ef3d805f6e50bc488f8e4e9e353068b78c73d17f
Cr-Commit-Position: refs/heads/master@{#11201}

[tommi, 2016-01-11 15:45:40]

drive by minor requests/suggestions for upcoming changes

https://codereview.webrtc.org/1578713002/diff/1/webrtc/modules/rtp_rtcp/sourc...
File webrtc/modules/rtp_rtcp/source/rtcp_packet/tmmbn.cc (right):

https://codereview.webrtc.org/1578713002/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtcp_packet/tmmbn.cc:27: void
AssignUWord32(uint8_t* buffer, size_t* offset, uint32_t value) {
empty line above this one

https://codereview.webrtc.org/1578713002/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtcp_packet/tmmbn.cc:91: assert(overhead <=
0x1ff);
use RTC_DCHECK

https://codereview.webrtc.org/1578713002/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtcp_packet/tmmbn.cc:92: if (tmmbn_items_.size()
>= kMaxNumberOfTmmbrs) {
assuming single threaded?  If so, please use ThreadChecker

https://codereview.webrtc.org/1578713002/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtcp_packet/tmmbn.cc:108: while (*index +
BlockLength() > max_length) {
would also be good to state the threading model here.

https://codereview.webrtc.org/1578713002/diff/1/webrtc/modules/rtp_rtcp/sourc...
File webrtc/modules/rtp_rtcp/source/rtcp_packet/tmmbn.h (right):

https://codereview.webrtc.org/1578713002/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtcp_packet/tmmbn.h:27: memset(&tmmbn_, 0,
sizeof(tmmbn_));
fyi - I think you should be able to do the same thing this way:

Tmmbn() : RtcpPacket(), tmmbn_() {}

https://codereview.webrtc.org/1578713002/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtcp_packet/tmmbn.h:30: virtual ~Tmmbn() {}
override

https://codereview.webrtc.org/1578713002/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtcp_packet/tmmbn.h:33: tmmbn_.SenderSSRC = ssrc;
doesn't look like this is thread safe. On which thread is this called?