Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 1578373003: Clean the code for external denoiser. (Closed)

Created:
4 years, 11 months ago by jackychen_
Modified:
4 years, 11 months ago
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Clean the code for external denoiser. BUG=webrtc:5255 Committed: https://crrev.com/a276e731683c673388cf3aeaa1888a5bcc3e1dc0 Cr-Commit-Position: refs/heads/master@{#11235}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -30 lines) Patch
M webrtc/common_video/video_frame.cc View 1 2 chunks +18 lines, -21 lines 0 comments Download
M webrtc/modules/video_processing/util/denoiser_filter.h View 2 chunks +2 lines, -1 line 0 comments Download
M webrtc/modules/video_processing/util/denoiser_filter.cc View 2 chunks +11 lines, -8 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
tommi
lgtm https://codereview.webrtc.org/1578373003/diff/1/webrtc/modules/video_processing/util/denoiser_filter.cc File webrtc/modules/video_processing/util/denoiser_filter.cc (right): https://codereview.webrtc.org/1578373003/diff/1/webrtc/modules/video_processing/util/denoiser_filter.cc#newcode24 webrtc/modules/video_processing/util/denoiser_filter.cc:24: rtc::scoped_ptr<DenoiserFilter> DenoiserFilter::Create( thanks!
4 years, 11 months ago (2016-01-13 09:33:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1578373003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1578373003/1
4 years, 11 months ago (2016-01-13 09:33:08 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_rel on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_rel/builds/12022)
4 years, 11 months ago (2016-01-13 09:40:47 UTC) #8
tommi
https://codereview.webrtc.org/1578373003/diff/1/webrtc/common_video/video_frame.cc File webrtc/common_video/video_frame.cc (right): https://codereview.webrtc.org/1578373003/diff/1/webrtc/common_video/video_frame.cc#newcode39 webrtc/common_video/video_frame.cc:39: return plane_stride * (image_height + 1) / 2; hmm... ...
4 years, 11 months ago (2016-01-13 09:45:10 UTC) #9
jackychen_
On 2016/01/13 09:45:10, tommi-webrtc wrote: > https://codereview.webrtc.org/1578373003/diff/1/webrtc/common_video/video_frame.cc > File webrtc/common_video/video_frame.cc (right): > > https://codereview.webrtc.org/1578373003/diff/1/webrtc/common_video/video_frame.cc#newcode39 > ...
4 years, 11 months ago (2016-01-13 10:21:00 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1578373003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1578373003/20001
4 years, 11 months ago (2016-01-13 10:25:07 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-13 13:36:36 UTC) #15
commit-bot: I haz the power
4 years, 11 months ago (2016-01-13 13:36:48 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a276e731683c673388cf3aeaa1888a5bcc3e1dc0
Cr-Commit-Position: refs/heads/master@{#11235}

Powered by Google App Engine
This is Rietveld 408576698