Chromium Code Reviews

Issue 1577853005: Fix capture ntp time issue introduced with r11187. (Closed)

Created:
4 years, 11 months ago by stefan-webrtc
Modified:
4 years, 11 months ago
Reviewers:
pbos-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, the sun, pbos-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix capture ntp time issue introduced with r11187. I think the problem was that I only introduced delay in one direction, and the estimation assumes that the RTT is evenly divided between the send direction and the receive direction, which was true for the old test. BUG=chromium:576246 R=pbos@webrtc.org Committed: https://crrev.com/ea8c0f6fcbd79fd3933cf2f2511a8900c1a9344a Cr-Commit-Position: refs/heads/master@{#11233}

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+5 lines, -0 lines)
M webrtc/call/call_perf_tests.cc View 1 chunk +5 lines, -0 lines 0 comments

Messages

Total messages: 12 (6 generated)
stefan-webrtc
4 years, 11 months ago (2016-01-12 15:57:46 UTC) #2
pbos-webrtc
lgtm
4 years, 11 months ago (2016-01-12 16:11:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1577853005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1577853005/1
4 years, 11 months ago (2016-01-12 16:13:03 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL) linux_baremetal on ...
4 years, 11 months ago (2016-01-12 18:13:19 UTC) #8
stefan-webrtc
Committed patchset #1 (id:1) manually as ea8c0f6fcbd79fd3933cf2f2511a8900c1a9344a (presubmit successful).
4 years, 11 months ago (2016-01-13 07:58:57 UTC) #10
commit-bot: I haz the power
4 years, 11 months ago (2016-01-13 07:58:59 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ea8c0f6fcbd79fd3933cf2f2511a8900c1a9344a
Cr-Commit-Position: refs/heads/master@{#11233}

Powered by Google App Engine