[rtp_rtcp] rtcp header structure copied from RTCPUtility and extended

introduced rtcp::CommonHeader class
this class replace and extend RTCPUtility::RtcpCommonHeader structure and RTCPUtility::RtcpParseCommonHeader function.
In addition to header fields, payload pointer is stored because rtcp header without payload is rarely useful.
Sample usage can be checked in 'RTCP Parser sketched' CL: https://codereview.webrtc.org/1555683002/

BUG=webrtc:5260
R=asapersson@webrtc.org, sprang@webrtc.org

Committed: https://crrev.com/7021b92525cbcd99c83af35dfa4c3f355997246a
Cr-Commit-Position: refs/heads/master@{#11999}

[danilchap, 2016-02-12 15:31:43]

Description was changed from

==========
[rtp_rtcp] introduced ParsingPacket class
this class replace and extend RTCPUtility::RtcpCommonHeader structure and
RTCPUtility::RtcpParseCommonHeader function.
Sample usage can be checked in 'RTCP Parser sketched' CL:
https://codereview.webrtc.org/1555683002/

BUG=webrtc:5260
R=åsapersson
==========

to

==========
[rtp_rtcp] introduced rtcp::CommonHeader class
this class replace and extend RTCPUtility::RtcpCommonHeader structure and
RTCPUtility::RtcpParseCommonHeader function.
Sample usage can be checked in 'RTCP Parser sketched' CL:
https://codereview.webrtc.org/1555683002/

BUG=webrtc:5260
R=åsapersson
==========

[danilchap, 2016-02-12 15:34:12]

Description was changed from

==========
[rtp_rtcp] introduced rtcp::CommonHeader class
this class replace and extend RTCPUtility::RtcpCommonHeader structure and
RTCPUtility::RtcpParseCommonHeader function.
Sample usage can be checked in 'RTCP Parser sketched' CL:
https://codereview.webrtc.org/1555683002/

BUG=webrtc:5260
R=åsapersson
==========

to

==========
[rtp_rtcp] introduced rtcp::CommonHeader class
this class replace and extend RTCPUtility::RtcpCommonHeader structure and
RTCPUtility::RtcpParseCommonHeader function.
In addition to header fields, payload pointer is stored since rtcp header
without payload is rarely useful.
Sample usage can be checked in 'RTCP Parser sketched' CL:
https://codereview.webrtc.org/1555683002/

BUG=webrtc:5260
R=åsapersson
==========

[danilchap, 2016-02-12 15:35:45]

Description was changed from

==========
[rtp_rtcp] introduced rtcp::CommonHeader class
this class replace and extend RTCPUtility::RtcpCommonHeader structure and
RTCPUtility::RtcpParseCommonHeader function.
In addition to header fields, payload pointer is stored since rtcp header
without payload is rarely useful.
Sample usage can be checked in 'RTCP Parser sketched' CL:
https://codereview.webrtc.org/1555683002/

BUG=webrtc:5260
R=åsapersson
==========

to

==========
introduced rtcp::CommonHeader class
this class replace and extend RTCPUtility::RtcpCommonHeader structure and
RTCPUtility::RtcpParseCommonHeader function.
In addition to header fields, payload pointer is stored because rtcp header
without payload is rarely useful.
Sample usage can be checked in 'RTCP Parser sketched' CL:
https://codereview.webrtc.org/1555683002/

BUG=webrtc:5260
R=åsapersson
==========

[danilchap, 2016-02-16 09:52:42]

Description was changed from

==========
introduced rtcp::CommonHeader class
this class replace and extend RTCPUtility::RtcpCommonHeader structure and
RTCPUtility::RtcpParseCommonHeader function.
In addition to header fields, payload pointer is stored because rtcp header
without payload is rarely useful.
Sample usage can be checked in 'RTCP Parser sketched' CL:
https://codereview.webrtc.org/1555683002/

BUG=webrtc:5260
R=åsapersson
==========

to

==========
introduced rtcp::CommonHeader class
this class replace and extend RTCPUtility::RtcpCommonHeader structure and
RTCPUtility::RtcpParseCommonHeader function.
In addition to header fields, payload pointer is stored because rtcp header
without payload is rarely useful.
Sample usage can be checked in 'RTCP Parser sketched' CL:
https://codereview.webrtc.org/1555683002/

BUG=webrtc:5260
==========

[danilchap, 2016-02-16 09:52:42]

danilchap@webrtc.org changed reviewers:
+ sprang@webrtc.org
- asapersson@webrtc.org

[sprang_webrtc, 2016-02-29 14:57:44]

sprang@webrtc.org changed reviewers:
+ stefan@webrtc.org

[sprang_webrtc, 2016-02-29 14:57:46]

lgtm with comments
+stefan as owner

https://codereview.webrtc.org/1575413002/diff/60001/webrtc/modules/rtp_rtcp/s...
File webrtc/modules/rtp_rtcp/source/rtcp_packet/common_header.h (right):

https://codereview.webrtc.org/1575413002/diff/60001/webrtc/modules/rtp_rtcp/s...
webrtc/modules/rtp_rtcp/source/rtcp_packet/common_header.h:20:
CommonHeader(const CommonHeader&) = default;
explicit?

https://codereview.webrtc.org/1575413002/diff/60001/webrtc/modules/rtp_rtcp/s...
File webrtc/modules/rtp_rtcp/source/rtcp_packet/common_header_unittest.cc
(right):

https://codereview.webrtc.org/1575413002/diff/60001/webrtc/modules/rtp_rtcp/s...
webrtc/modules/rtp_rtcp/source/rtcp_packet/common_header_unittest.cc:86:
EXPECT_EQ(buffer + sizeof(buffer), header.NextPacket());
Maybe also test:
 buffer[kPaddingAddress] = 0;
This should be illegal iirc.

[danilchap, 2016-02-29 15:39:56]

https://codereview.webrtc.org/1575413002/diff/60001/webrtc/modules/rtp_rtcp/s...
File webrtc/modules/rtp_rtcp/source/rtcp_packet/common_header.h (right):

https://codereview.webrtc.org/1575413002/diff/60001/webrtc/modules/rtp_rtcp/s...
webrtc/modules/rtp_rtcp/source/rtcp_packet/common_header.h:20:
CommonHeader(const CommonHeader&) = default;
On 2016/02/29 14:57:45, språng wrote:
> explicit?

explicit keyword is not expected for copy constructor.
explicit copy constructor/assign operator to explicitly show this class is
copy-able.

https://codereview.webrtc.org/1575413002/diff/60001/webrtc/modules/rtp_rtcp/s...
File webrtc/modules/rtp_rtcp/source/rtcp_packet/common_header_unittest.cc
(right):

https://codereview.webrtc.org/1575413002/diff/60001/webrtc/modules/rtp_rtcp/s...
webrtc/modules/rtp_rtcp/source/rtcp_packet/common_header_unittest.cc:86:
EXPECT_EQ(buffer + sizeof(buffer), header.NextPacket());
On 2016/02/29 14:57:45, språng wrote:
> Maybe also test:
>  buffer[kPaddingAddress] = 0;
> This should be illegal iirc.

Added this failing test, then fixed it.

[danilchap, 2016-03-03 09:39:37]

danilchap@webrtc.org changed reviewers:
+ asapersson@webrtc.org
- stefan@webrtc.org

[åsapersson, 2016-03-15 14:29:27]

lgtm

https://codereview.webrtc.org/1575413002/diff/100001/webrtc/modules/rtp_rtcp/...
File webrtc/modules/rtp_rtcp/source/rtcp_packet/common_header.h (right):

https://codereview.webrtc.org/1575413002/diff/100001/webrtc/modules/rtp_rtcp/...
webrtc/modules/rtp_rtcp/source/rtcp_packet/common_header.h:32: // Returns
pointer to the next RTCP packet in Compound packet.
compound

[danilchap, 2016-03-15 15:21:22]

https://codereview.webrtc.org/1575413002/diff/100001/webrtc/modules/rtp_rtcp/...
File webrtc/modules/rtp_rtcp/source/rtcp_packet/common_header.h (right):

https://codereview.webrtc.org/1575413002/diff/100001/webrtc/modules/rtp_rtcp/...
webrtc/modules/rtp_rtcp/source/rtcp_packet/common_header.h:32: // Returns
pointer to the next RTCP packet in Compound packet.
On 2016/03/15 14:29:27, åsapersson wrote:
> compound

Done.

[commit-bot: I haz the power, 2016-03-15 16:39:49]

Description was changed from

==========
introduced rtcp::CommonHeader class
this class replace and extend RTCPUtility::RtcpCommonHeader structure and
RTCPUtility::RtcpParseCommonHeader function.
In addition to header fields, payload pointer is stored because rtcp header
without payload is rarely useful.
Sample usage can be checked in 'RTCP Parser sketched' CL:
https://codereview.webrtc.org/1555683002/

BUG=webrtc:5260
==========

to

==========
introduced rtcp::CommonHeader class
this class replace and extend RTCPUtility::RtcpCommonHeader structure and
RTCPUtility::RtcpParseCommonHeader function.
In addition to header fields, payload pointer is stored because rtcp header
without payload is rarely useful.
Sample usage can be checked in 'RTCP Parser sketched' CL:
https://codereview.webrtc.org/1555683002/

BUG=webrtc:5260
R=asapersson@webrtc.org, sprang@webrtc.org

Committed: https://crrev.com/7021b92525cbcd99c83af35dfa4c3f355997246a
Cr-Commit-Position: refs/heads/master@{#11999}
==========

[danilchap, 2016-03-15 16:39:50]

Description was changed from

==========
introduced rtcp::CommonHeader class
this class replace and extend RTCPUtility::RtcpCommonHeader structure and
RTCPUtility::RtcpParseCommonHeader function.
In addition to header fields, payload pointer is stored because rtcp header
without payload is rarely useful.
Sample usage can be checked in 'RTCP Parser sketched' CL:
https://codereview.webrtc.org/1555683002/

BUG=webrtc:5260
R=asapersson@webrtc.org, sprang@webrtc.org

Committed: https://crrev.com/7021b92525cbcd99c83af35dfa4c3f355997246a
Cr-Commit-Position: refs/heads/master@{#11999}
==========

to

==========
introduced rtcp::CommonHeader class
this class replace and extend RTCPUtility::RtcpCommonHeader structure and
RTCPUtility::RtcpParseCommonHeader function.
In addition to header fields, payload pointer is stored because rtcp header
without payload is rarely useful.
Sample usage can be checked in 'RTCP Parser sketched' CL:
https://codereview.webrtc.org/1555683002/

BUG=webrtc:5260
R=asapersson@webrtc.org, sprang@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/7021b92525cbcd99c83af35df...
==========

[commit-bot: I haz the power, 2016-03-15 16:39:50]

Patchset 7 (id:??) landed as
https://crrev.com/7021b92525cbcd99c83af35dfa4c3f355997246a
Cr-Commit-Position: refs/heads/master@{#11999}

[danilchap, 2016-03-15 16:39:52]

Committed patchset #7 (id:120001) manually as
7021b92525cbcd99c83af35dfa4c3f355997246a (presubmit successful).