Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(428)

Unified Diff: talk/app/webrtc/videotrack_unittest.cc

Issue 1575223003: Added mute logic to VideoTrackRenderers. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Leave critical section while generating the black frame. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: talk/app/webrtc/videotrack_unittest.cc
diff --git a/talk/app/webrtc/videotrack_unittest.cc b/talk/app/webrtc/videotrack_unittest.cc
index 013d925cd2f9f83cbd96a2009206a37f5638986c..0e84083d3f39a32f004fca1866f749d53d78778c 100644
--- a/talk/app/webrtc/videotrack_unittest.cc
+++ b/talk/app/webrtc/videotrack_unittest.cc
@@ -109,3 +109,38 @@ TEST_F(VideoTrackTest, RenderVideo) {
EXPECT_EQ(2, renderer_1->num_rendered_frames());
EXPECT_EQ(2, renderer_2->num_rendered_frames());
}
+
+// Test that disabling the track results in blacked out frames.
+TEST_F(VideoTrackTest, DisableTrackBlackout) {
+ rtc::scoped_ptr<FakeVideoTrackRenderer> renderer(
+ new FakeVideoTrackRenderer(video_track_.get()));
+
+ cricket::VideoRenderer* renderer_input =
+ video_track_->GetSource()->FrameInput();
+ ASSERT_FALSE(renderer_input == NULL);
+
+ cricket::WebRtcVideoFrame frame;
+ frame.InitToBlack(100, 200, 1, 1, 0);
+ // Make it not all-black
+ frame.GetUPlane()[0] = 0;
+
+ renderer_input->RenderFrame(&frame);
+ EXPECT_EQ(1, renderer->num_rendered_frames());
+ EXPECT_FALSE(renderer->black_frame());
+ EXPECT_EQ(100, renderer->width());
+ EXPECT_EQ(200, renderer->height());
+
+ video_track_->set_enabled(false);
+ renderer_input->RenderFrame(&frame);
+ EXPECT_EQ(2, renderer->num_rendered_frames());
+ EXPECT_TRUE(renderer->black_frame());
+ EXPECT_EQ(100, renderer->width());
+ EXPECT_EQ(200, renderer->height());
+
+ video_track_->set_enabled(true);
+ renderer_input->RenderFrame(&frame);
+ EXPECT_EQ(3, renderer->num_rendered_frames());
+ EXPECT_FALSE(renderer->black_frame());
+ EXPECT_EQ(100, renderer->width());
+ EXPECT_EQ(200, renderer->height());
+}

Powered by Google App Engine
This is Rietveld 408576698