Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1575023002: [rtp_rtcp] rtcp::Tmmbr moved into own file (Closed)

Created:
4 years, 11 months ago by danilchap
Modified:
4 years, 11 months ago
Reviewers:
åsapersson
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, stefan-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

[rtp_rtcp] rtcp::Tmmbr moved into own file BUG=webrtc:5260 R=åsapersson Committed: https://crrev.com/7e8145f05d5f6921ffca3d62e9c4d1301c1d8bcb Cr-Commit-Position: refs/heads/master@{#11206}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -170 lines) Patch
M webrtc/modules/modules.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/rtp_rtcp/BUILD.gn View 1 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/modules/rtp_rtcp/rtp_rtcp.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet.h View 1 chunk +0 lines, -53 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet.cc View 3 chunks +0 lines, -53 lines 0 comments Download
A + webrtc/modules/rtp_rtcp/source/rtcp_packet/tmmbr.h View 2 chunks +24 lines, -20 lines 0 comments Download
A + webrtc/modules/rtp_rtcp/source/rtcp_packet/tmmbr.cc View 4 chunks +12 lines, -26 lines 0 comments Download
A webrtc/modules/rtp_rtcp/source/rtcp_packet/tmmbr_unittest.cc View 1 chunk +43 lines, -0 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet_unittest.cc View 2 chunks +0 lines, -18 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_receiver_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_sender.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
danilchap
explicetly unchanged
4 years, 11 months ago (2016-01-11 11:42:04 UTC) #1
åsapersson
lgtm
4 years, 11 months ago (2016-01-11 13:59:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1575023002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1575023002/20001
4 years, 11 months ago (2016-01-11 16:21:38 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL) win_baremetal on ...
4 years, 11 months ago (2016-01-11 17:59:48 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1575023002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1575023002/20001
4 years, 11 months ago (2016-01-11 19:20:44 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-11 19:49:22 UTC) #10
commit-bot: I haz the power
4 years, 11 months ago (2016-01-11 19:49:29 UTC) #12
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/7e8145f05d5f6921ffca3d62e9c4d1301c1d8bcb
Cr-Commit-Position: refs/heads/master@{#11206}

Powered by Google App Engine
This is Rietveld 408576698