Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Unified Diff: talk/media/base/videoengine_unittest.h

Issue 1574963002: Deleted renderer-related SetSize methods, and all uses. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Added static cast when converting width and height from size_t to int. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: talk/media/base/videoengine_unittest.h
diff --git a/talk/media/base/videoengine_unittest.h b/talk/media/base/videoengine_unittest.h
index d7fa00d5582d4ca285b8e81ad160e95c994f8b07..dafc05aae32bc2be1a51c53380aef8d0f61c4fa2 100644
--- a/talk/media/base/videoengine_unittest.h
+++ b/talk/media/base/videoengine_unittest.h
@@ -456,6 +456,7 @@ class VideoMediaChannelTest : public testing::Test,
EXPECT_EQ(codec.id, GetPayloadType(p.get()));
}
// Tests that we only get a VideoRenderer::SetSize() callback when needed.
+ // TODO(nisse): Delete this test, since we no longer have SetSize?
pthatcher1 2016/01/11 18:42:08 Yes, just remove this.
nisse-webrtc 2016/01/12 08:03:47 Done.
void SendManyResizeOnce() {
cricket::VideoCodec codec(DefaultCodec());
EXPECT_TRUE(SetOneCodec(codec));
@@ -468,14 +469,12 @@ class VideoMediaChannelTest : public testing::Test,
EXPECT_FRAME_WAIT(2, codec.width, codec.height, kTimeout);
rtc::scoped_ptr<const rtc::Buffer> p(GetRtpPacket(0));
EXPECT_EQ(codec.id, GetPayloadType(p.get()));
- EXPECT_EQ(1, renderer_.num_set_sizes());
codec.width /= 2;
codec.height /= 2;
EXPECT_TRUE(SetOneCodec(codec));
EXPECT_TRUE(WaitAndSendFrame(30));
EXPECT_FRAME_WAIT(3, codec.width, codec.height, kTimeout);
- EXPECT_EQ(2, renderer_.num_set_sizes());
}
void SendReceiveManyAndGetStats(const cricket::VideoCodec& codec,
int duration_sec, int fps) {

Powered by Google App Engine
This is Rietveld 408576698