Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Unified Diff: talk/media/base/videoengine_unittest.h

Issue 1574963002: Deleted renderer-related SetSize methods, and all uses. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Rebase Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « talk/media/base/videocapturer_unittest.cc ('k') | talk/media/base/videorenderer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: talk/media/base/videoengine_unittest.h
diff --git a/talk/media/base/videoengine_unittest.h b/talk/media/base/videoengine_unittest.h
index d7fa00d5582d4ca285b8e81ad160e95c994f8b07..00ee92923d36afbb27715c4ec938206a7c88df8b 100644
--- a/talk/media/base/videoengine_unittest.h
+++ b/talk/media/base/videoengine_unittest.h
@@ -455,28 +455,6 @@ class VideoMediaChannelTest : public testing::Test,
rtc::scoped_ptr<const rtc::Buffer> p(GetRtpPacket(0));
EXPECT_EQ(codec.id, GetPayloadType(p.get()));
}
- // Tests that we only get a VideoRenderer::SetSize() callback when needed.
- void SendManyResizeOnce() {
- cricket::VideoCodec codec(DefaultCodec());
- EXPECT_TRUE(SetOneCodec(codec));
- EXPECT_TRUE(SetSend(true));
- EXPECT_TRUE(channel_->SetRenderer(kDefaultReceiveSsrc, &renderer_));
- EXPECT_EQ(0, renderer_.num_rendered_frames());
- EXPECT_TRUE(WaitAndSendFrame(30));
- EXPECT_FRAME_WAIT(1, codec.width, codec.height, kTimeout);
- EXPECT_TRUE(WaitAndSendFrame(30));
- EXPECT_FRAME_WAIT(2, codec.width, codec.height, kTimeout);
- rtc::scoped_ptr<const rtc::Buffer> p(GetRtpPacket(0));
- EXPECT_EQ(codec.id, GetPayloadType(p.get()));
- EXPECT_EQ(1, renderer_.num_set_sizes());
-
- codec.width /= 2;
- codec.height /= 2;
- EXPECT_TRUE(SetOneCodec(codec));
- EXPECT_TRUE(WaitAndSendFrame(30));
- EXPECT_FRAME_WAIT(3, codec.width, codec.height, kTimeout);
- EXPECT_EQ(2, renderer_.num_set_sizes());
- }
void SendReceiveManyAndGetStats(const cricket::VideoCodec& codec,
int duration_sec, int fps) {
EXPECT_TRUE(SetOneCodec(codec));
« no previous file with comments | « talk/media/base/videocapturer_unittest.cc ('k') | talk/media/base/videorenderer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698