Deleted renderer-related SetSize methods, and all uses.

talk/media/base/videorenderer.h

 /*
  * libjingle
  * Copyright 2004 Google Inc.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are met:
  *
  *  1. Redistributions of source code must retain the above copyright notice,
  *     this list of conditions and the following disclaimer.
  *  2. Redistributions in binary form must reproduce the above copyright notice,
@@ skipping 21 matching lines @@
 #include <string>
 #endif
 
 #include "webrtc/base/sigslot.h"
 
 namespace cricket {
 
 class VideoFrame;
 
 // Abstract interface for rendering VideoFrames.
 class VideoRenderer {

[nisse-webrtc, 2016/01/11 08:30:52]

Except for the RenderFrame return value, and the protection of the destructor,
this class declaration is identical to webrtc::VideoRendererInterface. Can we
simply delete one of the classes (and if so, which one to keep)?

I'd also prefer to rename it to something like VideoFrameSink, but that's less
important.

[tommi, 2016/01/11 10:17:42]

keep the webrtc:: one. It's a part of the public interface but cricket:: is an
implementation detail.

  public:
   virtual ~VideoRenderer() {}
-  // Called when the video has changed size. This is also used as an
-  // initialization method to set the UI size before any video frame
-  // rendered. webrtc::ExternalRenderer's FrameSizeChange will invoke this when
-  // it's called or later when a VideoRenderer is attached.
-  virtual bool SetSize(int width, int height, int reserved) = 0;
   // Called when a new frame is available for display.
   virtual bool RenderFrame(const VideoFrame *frame) = 0;
 
 #if !defined(NDEBUG)
   // Allow renderer dumping out rendered frames.
   virtual bool SetDumpPath(const std::string &path) { return true; }
 #endif
 };
 
 }  // namespace cricket
 
 #endif  // TALK_MEDIA_BASE_VIDEORENDERER_H_