Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(524)

Issue 1571653002: Update attributes to match gclibc's ansidecl.h (Closed)

Created:
4 years, 11 months ago by kjellander_webrtc
Modified:
4 years, 11 months ago
Reviewers:
tommi, kwiberg-webrtc
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, rwolff_gocast.it, yujie_mao (webrtc), tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Update attributes to match gclibc's ansidecl.h To ease use of WebRTC in other codebases, update some macros to match glibc's ansidecl.h, which uses double-underscores for attributes. NOTRY=True Committed: https://crrev.com/b71b4f0c7af57ef5b676c6ed70bf945282c90e3a Cr-Commit-Position: refs/heads/master@{#11185}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M webrtc/base/common.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/base/criticalsection.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/base/deprecation.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/typedefs.h View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
kjellander_webrtc
Ignore the purple bots. My alias for triggering compile-only trybots was outdated due to recent ...
4 years, 11 months ago (2016-01-08 08:03:35 UTC) #4
kwiberg-webrtc
lgtm. The underscores should be allowed per https://gcc.gnu.org/onlinedocs/gcc/Attribute-Syntax.html.
4 years, 11 months ago (2016-01-08 09:40:28 UTC) #5
kjellander_webrtc
+tommi for owners approval
4 years, 11 months ago (2016-01-08 10:25:43 UTC) #7
tommi
lgtm
4 years, 11 months ago (2016-01-08 11:06:54 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1571653002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1571653002/20001
4 years, 11 months ago (2016-01-08 12:47:45 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 11 months ago (2016-01-08 12:51:42 UTC) #13
commit-bot: I haz the power
4 years, 11 months ago (2016-01-08 12:51:55 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b71b4f0c7af57ef5b676c6ed70bf945282c90e3a
Cr-Commit-Position: refs/heads/master@{#11185}

Powered by Google App Engine
This is Rietveld 408576698