webrtc/call/call.cc - Issue 1571283002: Fixes a bug which incorrectly logs incoming RTCP as outgoing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/call/call.cc

Issue 1571283002: Fixes a bug which incorrectly logs incoming RTCP as outgoing. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Added RTC_DISALLOW_IMPLICT_CONSTRUCTORS Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: webrtc/call/call.cc

diff --git a/webrtc/call/call.cc b/webrtc/call/call.cc

index f8611398c3a5dfe95c4e376b0caa802a911a05a2..12c570c64e5ae58923e26dd6563dd8c3fdcd0ed0 100644

--- a/webrtc/call/call.cc

+++ b/webrtc/call/call.cc

@@ -678,7 +678,7 @@ PacketReceiver::DeliveryStatus Call::DeliverRtcp(MediaType media_type,

if (stream->DeliverRtcp(packet, length)) {

rtcp_delivered = true;

if (event_log_)

- event_log_->LogRtcpPacket(false, media_type, packet, length);

+ event_log_->LogRtcpPacket(true, media_type, packet, length);

}

« no previous file with comments | « no previous file | webrtc/call/rtc_event_log_unittest.cc » ('j') | webrtc/modules/rtp_rtcp/include/rtp_rtcp.h » ('J')