Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Unified Diff: webrtc/call/rtc_event_log.h

Issue 1571283002: Fixes a bug which incorrectly logs incoming RTCP as outgoing. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Rebase Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/call/mock/mock_rtc_event_log.h ('k') | webrtc/call/rtc_event_log.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/call/rtc_event_log.h
diff --git a/webrtc/call/rtc_event_log.h b/webrtc/call/rtc_event_log.h
index 489687a1953d64237b706d9237aae66005c76ca2..027f6867c6fea91d465c4e31718f6cc8b46d9d83 100644
--- a/webrtc/call/rtc_event_log.h
+++ b/webrtc/call/rtc_event_log.h
@@ -30,6 +30,8 @@ class RtcEventLogImpl;
enum class MediaType;
+enum PacketDirection { kIncomingPacket = 0, kOutgoingPacket };
+
class RtcEventLog {
public:
virtual ~RtcEventLog() {}
@@ -63,13 +65,13 @@ class RtcEventLog {
// Logs the header of an incoming or outgoing RTP packet. packet_length
// is the total length of the packet, including both header and payload.
- virtual void LogRtpHeader(bool incoming,
+ virtual void LogRtpHeader(PacketDirection direction,
MediaType media_type,
const uint8_t* header,
size_t packet_length) = 0;
// Logs an incoming or outgoing RTCP packet.
- virtual void LogRtcpPacket(bool incoming,
+ virtual void LogRtcpPacket(PacketDirection direction,
MediaType media_type,
const uint8_t* packet,
size_t length) = 0;
« no previous file with comments | « webrtc/call/mock/mock_rtc_event_log.h ('k') | webrtc/call/rtc_event_log.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698