Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Unified Diff: webrtc/call/call.cc

Issue 1571283002: Fixes a bug which incorrectly logs incoming RTCP as outgoing. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Rebase Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webrtc/call/mock/mock_rtc_event_log.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/call/call.cc
diff --git a/webrtc/call/call.cc b/webrtc/call/call.cc
index 14bfbccc36752944c313d8b4617d45678acc01f1..111bc4562cbca72e0e7b6a7f3336f8d494df4b20 100644
--- a/webrtc/call/call.cc
+++ b/webrtc/call/call.cc
@@ -666,7 +666,8 @@ PacketReceiver::DeliveryStatus Call::DeliverRtcp(MediaType media_type,
if (stream->DeliverRtcp(packet, length)) {
rtcp_delivered = true;
if (event_log_)
- event_log_->LogRtcpPacket(true, media_type, packet, length);
+ event_log_->LogRtcpPacket(kIncomingPacket, media_type, packet,
+ length);
}
}
}
@@ -676,7 +677,8 @@ PacketReceiver::DeliveryStatus Call::DeliverRtcp(MediaType media_type,
if (stream->DeliverRtcp(packet, length)) {
rtcp_delivered = true;
if (event_log_)
- event_log_->LogRtcpPacket(false, media_type, packet, length);
+ event_log_->LogRtcpPacket(kIncomingPacket, media_type, packet,
+ length);
}
}
}
@@ -706,7 +708,7 @@ PacketReceiver::DeliveryStatus Call::DeliverRtp(MediaType media_type,
? DELIVERY_OK
: DELIVERY_PACKET_ERROR;
if (status == DELIVERY_OK && event_log_)
- event_log_->LogRtpHeader(true, media_type, packet, length);
+ event_log_->LogRtpHeader(kIncomingPacket, media_type, packet, length);
return status;
}
}
@@ -718,7 +720,7 @@ PacketReceiver::DeliveryStatus Call::DeliverRtp(MediaType media_type,
? DELIVERY_OK
: DELIVERY_PACKET_ERROR;
if (status == DELIVERY_OK && event_log_)
- event_log_->LogRtpHeader(true, media_type, packet, length);
+ event_log_->LogRtpHeader(kIncomingPacket, media_type, packet, length);
return status;
}
}
« no previous file with comments | « no previous file | webrtc/call/mock/mock_rtc_event_log.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698