Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2993)

Unified Diff: webrtc/call/call.cc

Issue 1571283002: Fixes a bug which incorrectly logs incoming RTCP as outgoing. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webrtc/call/rtc_event_log_unittest.cc » ('j') | webrtc/modules/rtp_rtcp/include/rtp_rtcp.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/call/call.cc
diff --git a/webrtc/call/call.cc b/webrtc/call/call.cc
index f8611398c3a5dfe95c4e376b0caa802a911a05a2..12c570c64e5ae58923e26dd6563dd8c3fdcd0ed0 100644
--- a/webrtc/call/call.cc
+++ b/webrtc/call/call.cc
@@ -678,7 +678,7 @@ PacketReceiver::DeliveryStatus Call::DeliverRtcp(MediaType media_type,
if (stream->DeliverRtcp(packet, length)) {
rtcp_delivered = true;
if (event_log_)
- event_log_->LogRtcpPacket(false, media_type, packet, length);
+ event_log_->LogRtcpPacket(true, media_type, packet, length);
pbos-webrtc 2016/01/11 12:16:56 Can we change this into an enum that has kIncoming
terelius 2016/01/11 12:22:52 I suppose we could do that, though I think the ori
the sun 2016/01/11 12:36:16 +1
terelius 2016/01/11 13:07:20 There is an enum RTPDirections in common_types.h.
terelius 2016/01/13 17:08:18 Added an enum in rtc_event_log.h
}
}
}
« no previous file with comments | « no previous file | webrtc/call/rtc_event_log_unittest.cc » ('j') | webrtc/modules/rtp_rtcp/include/rtp_rtcp.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698