Remove additional channel constraints when Beamforming is enabled in AudioProcessing

Remove additional channel constraints when Beamforming is enabled in AudioProcessing

The general constraints on number of channels for AudioProcessing is:
num_in_channels == num_out_channels || num_out_channels == 1

When Beamforming is enabled and additional constraint was added forcing:
num_out_channels == 1

This artificial constraint was removed by adding upmixing support in CopyTo, since it was already supported for the AudioFrame interface using InterleaveTo.

Committed: https://crrev.com/b2328d11dcc86fba1661ee3fa0d51fc126939764
Cr-Commit-Position: refs/heads/master@{#11215}

[aluebs-webrtc, 2016-01-09 01:59:45]

aluebs@webrtc.org changed reviewers:
+ henrik.lundin@webrtc.org

[aluebs-webrtc, 2016-01-09 03:09:13]

Description was changed from

==========
Remove additional channel constraints when Beamforming is enabled in
AudioProcessing

The general constraints on number of channels for AudioProcessing is:
num_in_channels == num_out_channels || num_out_channels == 1

When Beamforming is enabled and additional constraint was added forcing:
num_out_channels == 1

This artificial constraint was removed by adding upmixing support in CopyTo,
since it was already supported for the AudioFrame interface using InterleaveTo.
==========

to

==========
Remove additional channel constraints when Beamforming is enabled in
AudioProcessing

The general constraints on number of channels for AudioProcessing is:
num_in_channels == num_out_channels || num_out_channels == 1

When Beamforming is enabled and additional constraint was added forcing:
num_out_channels == 1

This artificial constraint was removed by adding upmixing support in CopyTo,
since it was already supported for the AudioFrame interface using InterleaveTo.
==========

[aluebs-webrtc, 2016-01-09 03:09:14]

aluebs@webrtc.org changed reviewers:
+ solenberg@webrtc.org

[aluebs-webrtc, 2016-01-09 03:09:41]

Adding solenberg as a reviewer for talk/media/webrtc

[the sun, 2016-01-11 12:21:19]

lgtm for talk/media/webrtc

[hlundin-webrtc, 2016-01-11 16:07:23]

lgtm

https://codereview.webrtc.org/1571013002/diff/1/webrtc/modules/audio_processi...
File webrtc/modules/audio_processing/audio_buffer.cc (right):

https://codereview.webrtc.org/1571013002/diff/1/webrtc/modules/audio_processi...
webrtc/modules/audio_processing/audio_buffer.cc:177: // Upmix
Nit: Upmix.

[aluebs-webrtc, 2016-01-12 01:46:02]

The CQ bit was checked by aluebs@webrtc.org

[aluebs-webrtc, 2016-01-12 01:46:03]

The patchset sent to the CQ was uploaded after l-g-t-m from
solenberg@webrtc.org, henrik.lundin@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1571013002/#ps20001 (title:
"Formatting")

[commit-bot: I haz the power, 2016-01-12 01:46:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1571013002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1571013002/20001

[commit-bot: I haz the power, 2016-01-12 02:07:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-12 02:07:49]

Try jobs failed on following builders:
  mac_baremetal on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_baremetal/builds/8391)

[aluebs-webrtc, 2016-01-12 02:22:50]

The CQ bit was checked by aluebs@webrtc.org

[commit-bot: I haz the power, 2016-01-12 02:22:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1571013002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1571013002/20001

[commit-bot: I haz the power, 2016-01-12 02:24:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-12 02:24:41]

Try jobs failed on following builders:
  presubmit on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/2791)

[aluebs-webrtc, 2016-01-12 03:03:12]

The CQ bit was checked by aluebs@webrtc.org

[aluebs-webrtc, 2016-01-12 03:03:13]

The patchset sent to the CQ was uploaded after l-g-t-m from
solenberg@webrtc.org, henrik.lundin@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1571013002/#ps40001 (title:
"Rebasing")

[commit-bot: I haz the power, 2016-01-12 03:03:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1571013002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1571013002/40001

[commit-bot: I haz the power, 2016-01-12 04:32:32]

Description was changed from

==========
Remove additional channel constraints when Beamforming is enabled in
AudioProcessing

The general constraints on number of channels for AudioProcessing is:
num_in_channels == num_out_channels || num_out_channels == 1

When Beamforming is enabled and additional constraint was added forcing:
num_out_channels == 1

This artificial constraint was removed by adding upmixing support in CopyTo,
since it was already supported for the AudioFrame interface using InterleaveTo.
==========

to

==========
Remove additional channel constraints when Beamforming is enabled in
AudioProcessing

The general constraints on number of channels for AudioProcessing is:
num_in_channels == num_out_channels || num_out_channels == 1

When Beamforming is enabled and additional constraint was added forcing:
num_out_channels == 1

This artificial constraint was removed by adding upmixing support in CopyTo,
since it was already supported for the AudioFrame interface using InterleaveTo.
==========

[commit-bot: I haz the power, 2016-01-12 04:32:34]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-01-12 04:32:35]

Description was changed from

==========
Remove additional channel constraints when Beamforming is enabled in
AudioProcessing

The general constraints on number of channels for AudioProcessing is:
num_in_channels == num_out_channels || num_out_channels == 1

When Beamforming is enabled and additional constraint was added forcing:
num_out_channels == 1

This artificial constraint was removed by adding upmixing support in CopyTo,
since it was already supported for the AudioFrame interface using InterleaveTo.
==========

to

==========
Remove additional channel constraints when Beamforming is enabled in
AudioProcessing

The general constraints on number of channels for AudioProcessing is:
num_in_channels == num_out_channels || num_out_channels == 1

When Beamforming is enabled and additional constraint was added forcing:
num_out_channels == 1

This artificial constraint was removed by adding upmixing support in CopyTo,
since it was already supported for the AudioFrame interface using InterleaveTo.

Committed: https://crrev.com/b2328d11dcc86fba1661ee3fa0d51fc126939764
Cr-Commit-Position: refs/heads/master@{#11215}
==========

[commit-bot: I haz the power, 2016-01-12 04:32:36]

Patchset 3 (id:??) landed as
https://crrev.com/b2328d11dcc86fba1661ee3fa0d51fc126939764
Cr-Commit-Position: refs/heads/master@{#11215}