Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(724)

Issue 1570513004: Reland "Add APK targets to build libjingle tests for Android." (Closed)

Created:
4 years, 11 months ago by phoglund
Modified:
4 years, 11 months ago
Reviewers:
tommi, perkj_webrtc
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), henrika_webrtc, zhengzhonghou_agora.io, tterriberry_mozilla.com, fengyue_agora.io, qiang.lu, niklas.enbom, peah-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland "Add APK targets to build libjingle tests for Android." patchset #10 id:180001 of https://codereview.webrtc.org/1511633002/ This reverts commit bc14164aad254e72ce4d1e381b912b7d3acf5391. We have made more preparations downstream, so this should work now. Original CL by perkj@. BUG=webrtc:2365 The work started from the work by kjellander@ in https://codereview.webrtc.org/1413663003/ Committed: https://crrev.com/37ebcf0ce5ad1685bcf659ea75960beb96019647 Cr-Commit-Position: refs/heads/master@{#11186}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+256 lines, -124 lines) Patch
A + talk/app/webrtc/java/jni/jni_onload.cc View 1 chunk +24 lines, -5 lines 0 comments Download
M talk/app/webrtc/java/jni/peerconnection_jni.cc View 1 chunk +0 lines, -16 lines 0 comments Download
M talk/app/webrtc/peerconnectionendtoend_unittest.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M talk/app/webrtc/peerconnectionfactory_unittest.cc View 3 chunks +10 lines, -0 lines 0 comments Download
M talk/app/webrtc/peerconnectioninterface_unittest.cc View 2 chunks +9 lines, -0 lines 0 comments Download
A talk/app/webrtc/test/DEPS View 1 chunk +5 lines, -0 lines 0 comments Download
A + talk/app/webrtc/test/androidtestinitializer.h View 1 chunk +6 lines, -5 lines 0 comments Download
A + talk/app/webrtc/test/androidtestinitializer.cc View 1 chunk +34 lines, -28 lines 0 comments Download
M talk/app/webrtc/webrtcsdp_unittest.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M talk/libjingle.gyp View 5 chunks +50 lines, -33 lines 0 comments Download
M talk/libjingle_tests.gyp View 4 chunks +20 lines, -13 lines 0 comments Download
M webrtc/build/android/test_runner.py View 1 chunk +2 lines, -0 lines 0 comments Download
A webrtc/build/apk_test.gypi View 1 chunk +40 lines, -0 lines 0 comments Download
M webrtc/build/apk_tests.gyp View 1 chunk +17 lines, -0 lines 0 comments Download
M webrtc/build/apk_tests_noop.gyp View 1 chunk +4 lines, -0 lines 0 comments Download
M webrtc/system_wrappers/include/field_trial_default.h View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/system_wrappers/source/field_trial_default.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M webrtc/test/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/test/field_trial.h View 1 chunk +2 lines, -1 line 0 comments Download
M webrtc/test/field_trial.cc View 4 chunks +13 lines, -23 lines 0 comments Download
M webrtc/test/test.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
phoglund
4 years, 11 months ago (2016-01-08 10:23:50 UTC) #3
tommi
lgtm bonne chance
4 years, 11 months ago (2016-01-08 11:05:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1570513004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1570513004/1
4 years, 11 months ago (2016-01-08 12:06:41 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-08 13:05:01 UTC) #8
commit-bot: I haz the power
4 years, 11 months ago (2016-01-08 13:05:07 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/37ebcf0ce5ad1685bcf659ea75960beb96019647
Cr-Commit-Position: refs/heads/master@{#11186}

Powered by Google App Engine
This is Rietveld 408576698