Replace manual casting to rvalue reference with calls to std::move

webrtc/base/optional_unittest.cc

 /*
  *  Copyright 2015 The WebRTC Project Authors. All rights reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 144 matching lines @@
               "---", "2:0. copy constructor (from 1:0)", "---",
               "2:0. destructor", "1:0. destructor", "0:0. destructor"),
             *log);
 }
 
 TEST(OptionalTest, TestConstructMoveEmpty) {
   auto log = Logger::Setup();
   {
     Optional<Logger> x;
     EXPECT_FALSE(x);
-    auto y = static_cast<Optional<Logger>&&>(x);
+    auto y = std::move(x);
     EXPECT_FALSE(y);
   }
   EXPECT_EQ(V("0:0. default constructor", "1:0. move constructor (from 0:0)",
               "1:0. destructor", "0:0. destructor"),
             *log);
 }
 
 TEST(OptionalTest, TestConstructMoveFull) {
   auto log = Logger::Setup();
   {
     Optional<Logger> x(Logger(17));
     EXPECT_TRUE(x);
     log->push_back("---");
-    auto y = static_cast<Optional<Logger>&&>(x);
+    auto y = std::move(x);
     EXPECT_TRUE(x);
     EXPECT_TRUE(y);
     log->push_back("---");
   }
   EXPECT_EQ(
       V("0:17. explicit constructor", "1:17. move constructor (from 0:17)",
         "0:17. destructor", "---", "2:17. move constructor (from 1:17)", "---",
         "2:17. destructor", "1:17. destructor"),
       *log);
 }
@@ skipping 92 matching lines @@
         "3:42. copy constructor (from 2:42)",
         "1:42. operator= move (from 3:42)", "3:42. destructor", "---",
         "2:42. destructor", "1:42. destructor"),
       *log);
 }
 
 TEST(OptionalTest, TestMoveAssignToEmptyFromEmpty) {
   auto log = Logger::Setup();
   {
     Optional<Logger> x, y;
-    x = static_cast<Optional<Logger>&&>(y);
+    x = std::move(y);
   }
   EXPECT_EQ(
       V("0:0. default constructor", "1:1. default constructor",
         "0:1. operator= move (from 1:1)", "1:1. destructor", "0:1. destructor"),
       *log);
 }
 
 TEST(OptionalTest, TestMoveAssignToFullFromEmpty) {
   auto log = Logger::Setup();
   {
     Optional<Logger> x(Logger(17));
     Optional<Logger> y;
     log->push_back("---");
-    x = static_cast<Optional<Logger>&&>(y);
+    x = std::move(y);
     log->push_back("---");
   }
   EXPECT_EQ(
       V("0:17. explicit constructor", "1:17. move constructor (from 0:17)",
         "0:17. destructor", "2:2. default constructor", "---",
         "1:2. operator= move (from 2:2)", "---", "2:2. destructor",
         "1:2. destructor"),
       *log);
 }
 
 TEST(OptionalTest, TestMoveAssignToEmptyFromFull) {
   auto log = Logger::Setup();
   {
     Optional<Logger> x;
     Optional<Logger> y(Logger(17));
     log->push_back("---");
-    x = static_cast<Optional<Logger>&&>(y);
+    x = std::move(y);
     log->push_back("---");
   }
   EXPECT_EQ(V("0:0. default constructor", "1:17. explicit constructor",
               "2:17. move constructor (from 1:17)", "1:17. destructor", "---",
               "0:17. operator= move (from 2:17)", "---", "2:17. destructor",
               "0:17. destructor"),
             *log);
 }
 
 TEST(OptionalTest, TestMoveAssignToFullFromFull) {
   auto log = Logger::Setup();
   {
     Optional<Logger> x(Logger(17));
     Optional<Logger> y(Logger(42));
     log->push_back("---");
-    x = static_cast<Optional<Logger>&&>(y);
+    x = std::move(y);
     log->push_back("---");
   }
   EXPECT_EQ(
       V("0:17. explicit constructor", "1:17. move constructor (from 0:17)",
         "0:17. destructor", "2:42. explicit constructor",
         "3:42. move constructor (from 2:42)", "2:42. destructor", "---",
         "1:42. operator= move (from 3:42)", "---", "3:42. destructor",
         "1:42. destructor"),
       *log);
 }
 
 TEST(OptionalTest, TestMoveAssignToEmptyFromT) {
   auto log = Logger::Setup();
   {
     Optional<Logger> x;
     Logger y(17);
     log->push_back("---");
-    x = Optional<Logger>(static_cast<Logger&&>(y));
+    x = Optional<Logger>(std::move(y));
     log->push_back("---");
   }
   EXPECT_EQ(V("0:0. default constructor", "1:17. explicit constructor", "---",
               "2:17. move constructor (from 1:17)",
               "0:17. operator= move (from 2:17)", "2:17. destructor", "---",
               "1:17. destructor", "0:17. destructor"),
             *log);
 }
 
 TEST(OptionalTest, TestMoveAssignToFullFromT) {
   auto log = Logger::Setup();
   {
     Optional<Logger> x(Logger(17));
     Logger y(42);
     log->push_back("---");
-    x = Optional<Logger>(static_cast<Logger&&>(y));
+    x = Optional<Logger>(std::move(y));
     log->push_back("---");
   }
   EXPECT_EQ(
       V("0:17. explicit constructor", "1:17. move constructor (from 0:17)",
         "0:17. destructor", "2:42. explicit constructor", "---",
         "3:42. move constructor (from 2:42)",
         "1:42. operator= move (from 3:42)", "3:42. destructor", "---",
         "2:42. destructor", "1:42. destructor"),
       *log);
 }
 
 TEST(OptionalTest, TestDereference) {
   auto log = Logger::Setup();
   {
     Optional<Logger> x(Logger(42));
     const auto& y = x;
     log->push_back("---");
     x->Foo();
     y->Foo();
-    static_cast<Optional<Logger>&&>(x)->Foo();
-    static_cast<const Optional<Logger>&&>(y)->Foo();
+    std::move(x)->Foo();
+    std::move(y)->Foo();
     log->push_back("---");
     (*x).Foo();
     (*y).Foo();
-    (*static_cast<Optional<Logger>&&>(x)).Foo();
-    (*static_cast<const Optional<Logger>&&>(y)).Foo();
+    (*std::move(x)).Foo();
+    (*std::move(y)).Foo();
     log->push_back("---");
   }
   EXPECT_EQ(V("0:42. explicit constructor",
               "1:42. move constructor (from 0:42)", "0:42. destructor", "---",
               "1:42. Foo()", "1:42. Foo() const", "1:42. Foo()",
               "1:42. Foo() const", "---", "1:42. Foo()", "1:42. Foo() const",
               "1:42. Foo()", "1:42. Foo() const", "---", "1:42. destructor"),
             *log);
 }
 
@@ skipping 70 matching lines @@
               "4:17. copy constructor (from 0:17)", "5:5. default constructor",
               "6:6. default constructor", "7:7. default constructor", "---",
               "swap 2:42, 3:17", "swap 4:5, 5:17", "swap 6:7, 7:6", "---",
               "7:6. destructor", "6:7. destructor", "5:17. destructor",
               "4:5. destructor", "3:17. destructor", "2:42. destructor",
               "1:42. destructor", "0:17. destructor"),
             *log);
 }
 
 }  // namespace rtc