Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(690)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1570473002: Replace manual casting to rvalue reference with calls to std::move (Closed)

Created:
4 years, 11 months ago by kwiberg-webrtc
Modified:
4 years, 11 months ago
Reviewers:
tommi
CC:
webrtc-reviews_webrtc.org, henrika_webrtc, zhengzhonghou_agora.io, tterriberry_mozilla.com, fengyue_agora.io, peah-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Replace manual casting to rvalue reference with calls to std::move Committed: https://crrev.com/cea7c2f7839eef81ecbd6dd10d103190ef68875c Cr-Commit-Position: refs/heads/master@{#11163}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -23 lines) Patch
M webrtc/base/buffer.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/base/optional.h View 1 chunk +3 lines, -4 lines 0 comments Download
M webrtc/base/optional_unittest.cc View 9 chunks +12 lines, -12 lines 0 comments Download
M webrtc/base/scoped_ptr.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/system_wrappers/include/scoped_vector.h View 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
kwiberg-webrtc
4 years, 11 months ago (2016-01-07 13:01:12 UTC) #2
tommi
lgtm
4 years, 11 months ago (2016-01-07 13:08:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1570473002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1570473002/1
4 years, 11 months ago (2016-01-07 13:14:13 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-07 13:52:08 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-07 13:52:13 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/cea7c2f7839eef81ecbd6dd10d103190ef68875c
Cr-Commit-Position: refs/heads/master@{#11163}

Powered by Google App Engine
This is Rietveld 408576698