Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 1570443012: Revert of Reland 1531763006 (Closed)

Created:
4 years, 11 months ago by guidou
Modified:
4 years, 11 months ago
Reviewers:
guoweis_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Reland 1531763006 (patchset #2 id:20001 of https://codereview.webrtc.org/1551703002/ ) Reason for revert: This is preventing a webrtc roll into chromium. See https://codereview.chromium.org/1572843002/ Original issue's description: > Reland 1531763006 > > Enable IPv6 temporary address filtering on iOS. > > We'll only use temporary address for IPv6. However, due to a bug in iOS sdk, the necessary headers are not included. This change copies the minimum necessary definitions such that we could retrieve the ip attributes. > > BUG=webrtc:4343 > > Committed: https://crrev.com/29488c23644721c10a45eba74c67602b0262e582 > Cr-Commit-Position: refs/heads/master@{#11114} > > patch from issue 1531763006 at patchset 200001 (http://crrev.com/1531763006#ps200001) > > TBR=pthatcher@webrtc.org > > Committed: https://crrev.com/9faf154960767e96afdf8a280a0a5c6c7e402f67 > Cr-Commit-Position: refs/heads/master@{#11133} TBR=guoweis@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:4343

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -467 lines) Patch
M webrtc/base/BUILD.gn View 2 chunks +0 lines, -6 lines 0 comments Download
M webrtc/base/base.gyp View 3 chunks +0 lines, -7 lines 0 comments Download
D webrtc/base/ifaddrs_converter.h View 1 chunk +0 lines, -45 lines 0 comments Download
D webrtc/base/ifaddrs_converter.cc View 1 chunk +0 lines, -60 lines 0 comments Download
D webrtc/base/macifaddrs_converter.cc View 1 chunk +0 lines, -281 lines 0 comments Download
M webrtc/base/network.h View 2 chunks +0 lines, -2 lines 0 comments Download
M webrtc/base/network.cc View 5 chunks +44 lines, -39 lines 0 comments Download
M webrtc/base/network_unittest.cc View 5 chunks +7 lines, -27 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
guidou
Created Revert of Reland 1531763006
4 years, 11 months ago (2016-01-09 11:36:41 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1570443012/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1570443012/1
4 years, 11 months ago (2016-01-09 11:36:52 UTC) #2
commit-bot: I haz the power
4 years, 11 months ago (2016-01-09 11:37:49 UTC) #4
Try jobs failed on following builders:
  android_compile_x86_dbg on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_compile_x86_dbg...)
  ios32_sim_dbg on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios32_sim_dbg/builds/4377)
  ios64_sim_dbg on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios64_sim_dbg/builds/4372)
  ios_arm64_dbg on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_arm64_dbg/builds/6692)
  ios_arm64_rel on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_arm64_rel/builds/6620)
  ios_dbg on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_dbg/builds/11858)
  ios_rel on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_rel/builds/10516)
  linux_asan on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_asan/builds/11724)
  linux_libfuzzer_rel on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_libfuzzer_rel/bui...)
  mac_asan on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_asan/builds/11652)
  mac_baremetal on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_baremetal/builds/8347)
  mac_compile_dbg on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_compile_dbg/builds/...)
  mac_gn_dbg on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_gn_dbg/builds/52)
  mac_gn_rel on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_gn_rel/builds/6289)
  mac_rel on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_rel/builds/11956)

Powered by Google App Engine
This is Rietveld 408576698