Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 1570403002: Revert of Roll chromium_revision 7d97c94..951c006 (368514:368525) (Closed)

Created:
4 years, 11 months ago by guoweis_webrtc
Modified:
4 years, 11 months ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Roll chromium_revision 7d97c94..951c006 (368514:368525) (patchset #1 id:1 of https://codereview.webrtc.org/1577573002/ ) Reason for revert: Win DrMemory Full: video_engine_tests failed 1 https://build.chromium.org/p/client.webrtc/builders/Win%20DrMemory%20Full/builds/3465 Original issue's description: > Roll chromium_revision 7d97c94..951c006 (368514:368525) > > Change log: https://chromium.googlesource.com/chromium/src/+log/7d97c94..951c006 > Full diff: https://chromium.googlesource.com/chromium/src/+/7d97c94..951c006 > > No dependencies changed. > No update to Clang. > > TBR= > > Committed: https://crrev.com/6109fc13aadebf7c5a990bbc78e981ab215321a6 > Cr-Commit-Position: refs/heads/master@{#11195} TBR=kjellander@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/daa87497e86b8f63858c8a60899494cc0bbf4e04 Cr-Commit-Position: refs/heads/master@{#11197}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
guoweis_webrtc
Created Revert of Roll chromium_revision 7d97c94..951c006 (368514:368525)
4 years, 11 months ago (2016-01-10 03:27:08 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1570403002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1570403002/1
4 years, 11 months ago (2016-01-10 03:27:20 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-10 03:27:33 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/daa87497e86b8f63858c8a60899494cc0bbf4e04 Cr-Commit-Position: refs/heads/master@{#11197}
4 years, 11 months ago (2016-01-10 03:27:41 UTC) #6
kjellander_webrtc
4 years, 11 months ago (2016-01-10 05:37:09 UTC) #7
Message was sent while issue was closed.
I suggest disabling the test and filing a bug for future situations like this,
since we have an auto-roller that will continue to roll forward anyway.

Then problem here is that Dr Memory full doens't run as part of the trybots for
the CQ since it's just too slow.

Powered by Google App Engine
This is Rietveld 408576698