Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1568853002:
Revert changes to default option setting in https://codereview.webrtc.org/1500633002/ (Closed)
DescriptionRevert changes to default option setting in https://codereview.webrtc.org/1500633002/
As found by aluebs@, the changes breaks ability to create AecDumps: https://codereview.webrtc.org/1530333007/
BUG=webrtc:4690
Committed: https://crrev.com/0f7d2939e0b3dd0b80d31583d4631600f7c26932
Cr-Commit-Position: refs/heads/master@{#11265}
Patch Set 1 #Patch Set 2 : rebase #Patch Set 3 : rebase #Messages
Total messages: 25 (13 generated)
solenberg@webrtc.org changed reviewers: + aluebs@webrtc.org, pthatcher@webrtc.org
Description was changed from ========== Revert changes to default option setting in https://codereview.webrtc.org/1500633002/ BUG=webrtc:4690 ========== to ========== Revert changes to default option setting in https://codereview.webrtc.org/1500633002/ As found by aluebs@, the changes breaks ability to create AecDumps: https://codereview.webrtc.org/1530333007/ BUG=webrtc:4690 ==========
aluebs@google.com changed reviewers: + aluebs@google.com
lgtm
lgtm
solenberg@webrtc.org changed reviewers: + tommi@webrtc.org - pthatcher@webrtc.org
solenberg@webrtc.org changed reviewers: + peah@webrtc.org - tommi@webrtc.org
On 2016/01/14 10:52:14, the sun wrote: > mailto:solenberg@webrtc.org changed reviewers: > + mailto:peah@webrtc.org > - mailto:tommi@webrtc.org lgtm
On 2016/01/14 10:52:14, the sun wrote: > mailto:solenberg@webrtc.org changed reviewers: > + mailto:peah@webrtc.org > - mailto:tommi@webrtc.org lgtm
The CQ bit was checked by solenberg@webrtc.org
The patchset sent to the CQ was uploaded after l-g-t-m from aluebs@google.com, aluebs@webrtc.org Link to the patchset: https://codereview.webrtc.org/1568853002/#ps40001 (title: "rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1568853002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1568853002/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL) linux_baremetal on tryserver.webrtc (JOB_TIMED_OUT, no build URL) win_baremetal on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by solenberg@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1568853002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1568853002/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by solenberg@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1568853002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1568853002/40001
Message was sent while issue was closed.
Description was changed from ========== Revert changes to default option setting in https://codereview.webrtc.org/1500633002/ As found by aluebs@, the changes breaks ability to create AecDumps: https://codereview.webrtc.org/1530333007/ BUG=webrtc:4690 ========== to ========== Revert changes to default option setting in https://codereview.webrtc.org/1500633002/ As found by aluebs@, the changes breaks ability to create AecDumps: https://codereview.webrtc.org/1530333007/ BUG=webrtc:4690 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Revert changes to default option setting in https://codereview.webrtc.org/1500633002/ As found by aluebs@, the changes breaks ability to create AecDumps: https://codereview.webrtc.org/1530333007/ BUG=webrtc:4690 ========== to ========== Revert changes to default option setting in https://codereview.webrtc.org/1500633002/ As found by aluebs@, the changes breaks ability to create AecDumps: https://codereview.webrtc.org/1530333007/ BUG=webrtc:4690 Committed: https://crrev.com/0f7d2939e0b3dd0b80d31583d4631600f7c26932 Cr-Commit-Position: refs/heads/master@{#11265} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/0f7d2939e0b3dd0b80d31583d4631600f7c26932 Cr-Commit-Position: refs/heads/master@{#11265} |
