Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 1567433002: Fix a flaky turnport test failure (Closed)

Created:
4 years, 11 months ago by honghaiz3
Modified:
4 years, 11 months ago
Reviewers:
pthatcher1
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, guoweis_webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix a flaky turnport test failure The connection was deleted asynchronously, so need to use EXPECT_TRUE_WAIT. BUG= TBR=pthatcher@webrtc.org Committed: https://crrev.com/b6802749f1c87e10b2442ecf3e75ba7b8ff45188 Cr-Commit-Position: refs/heads/master@{#11153}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M webrtc/p2p/base/turnport_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (7 generated)
honghaiz3
4 years, 11 months ago (2016-01-05 21:16:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1567433002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1567433002/20001
4 years, 11 months ago (2016-01-05 21:28:16 UTC) #7
honghaiz3
Committed patchset #1 (id:20001) manually as b6802749f1c87e10b2442ecf3e75ba7b8ff45188 (presubmit successful).
4 years, 11 months ago (2016-01-05 21:51:13 UTC) #9
commit-bot: I haz the power
4 years, 11 months ago (2016-01-05 21:51:17 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b6802749f1c87e10b2442ecf3e75ba7b8ff45188
Cr-Commit-Position: refs/heads/master@{#11153}

Powered by Google App Engine
This is Rietveld 408576698