Add helper macros for calling a histogram with different names.

Add helper macros for calling a histogram with different names.

To be used when a metric is used in different modes such as real-time vs screenshare (will be done in https://codereview.webrtc.org/1564923008/).

BUG=webrtc:5283
Committed: https://crrev.com/040b79ff7e4d5824a97ead0099d7ea84c2476c30
Cr-Commit-Position: refs/heads/master@{#11461}

[åsapersson, 2016-01-08 09:47:44]

Description was changed from

==========
sfs

BUG=
==========

to

==========
Add helper macros for calling a histogram with different names.

To be used when a metric is used in different modes such as real-time vs
screenshare.

BUG=webrtc:5283
==========

[åsapersson, 2016-01-15 16:30:13]

asapersson@webrtc.org changed reviewers:
+ mflodman@webrtc.org

[åsapersson, 2016-01-15 16:32:52]

asapersson@webrtc.org changed reviewers:
+ pbos@webrtc.org

[pbos-webrtc, 2016-01-18 14:57:58]

Shouldn't this be under some _SLOW label or something to annotate that it uses
the slow path? (It does, right?)

[pbos-webrtc, 2016-01-18 14:59:42]

Sorry, jumped the gun too quickly. LGTM.

[pbos-webrtc, 2016-01-18 15:01:14]

On the other hand, can you add the realtime vs. screenshare case to this CL so
that we have an example of real use?

[åsapersson, 2016-01-19 10:52:08]

Description was changed from

==========
Add helper macros for calling a histogram with different names.

To be used when a metric is used in different modes such as real-time vs
screenshare.

BUG=webrtc:5283
==========

to

==========
Add helper macros for calling a histogram with different names.

To be used when a metric is used in different modes such as real-time vs
screenshare (will be done in https://codereview.webrtc.org/1564923008/).

BUG=webrtc:5283
==========

[åsapersson, 2016-01-19 10:55:42]

On 2016/01/18 15:01:14, pbos-webrtc wrote:
> On the other hand, can you add the realtime vs. screenshare case to this CL so
> that we have an example of real use?

Have a separate CL for that (https://codereview.webrtc.org/1564923008/). Updated
description.

[pbos-webrtc, 2016-01-19 14:13:35]

https://codereview.webrtc.org/1567013004/diff/40001/webrtc/system_wrappers/in...
File webrtc/system_wrappers/include/metrics.h (right):

https://codereview.webrtc.org/1567013004/diff/40001/webrtc/system_wrappers/in...
webrtc/system_wrappers/include/metrics.h:190: RTC_DCHECK_GE(index, 0); \
RTC_DCHECK(index >= 0) so you can use both size_t and int here (I think).

[åsapersson, 2016-01-20 10:50:52]

https://codereview.webrtc.org/1567013004/diff/40001/webrtc/system_wrappers/in...
File webrtc/system_wrappers/include/metrics.h (right):

https://codereview.webrtc.org/1567013004/diff/40001/webrtc/system_wrappers/in...
webrtc/system_wrappers/include/metrics.h:190: RTC_DCHECK_GE(index, 0); \
On 2016/01/19 14:13:35, pbos-webrtc wrote:
> RTC_DCHECK(index >= 0) so you can use both size_t and int here (I think).

Done.

[mflodman, 2016-02-02 14:04:57]

LGTM

[åsapersson, 2016-02-02 14:11:11]

The CQ bit was checked by asapersson@webrtc.org

[åsapersson, 2016-02-02 14:11:11]

The patchset sent to the CQ was uploaded after l-g-t-m from pbos@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1567013004/#ps60001 (title:
"address comment")

[commit-bot: I haz the power, 2016-02-02 14:11:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1567013004/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1567013004/60001

[commit-bot: I haz the power, 2016-02-02 15:13:08]

Description was changed from

==========
Add helper macros for calling a histogram with different names.

To be used when a metric is used in different modes such as real-time vs
screenshare (will be done in https://codereview.webrtc.org/1564923008/).

BUG=webrtc:5283
==========

to

==========
Add helper macros for calling a histogram with different names.

To be used when a metric is used in different modes such as real-time vs
screenshare (will be done in https://codereview.webrtc.org/1564923008/).

BUG=webrtc:5283
==========

[commit-bot: I haz the power, 2016-02-02 15:13:09]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-02-02 15:13:27]

Description was changed from

==========
Add helper macros for calling a histogram with different names.

To be used when a metric is used in different modes such as real-time vs
screenshare (will be done in https://codereview.webrtc.org/1564923008/).

BUG=webrtc:5283
==========

to

==========
Add helper macros for calling a histogram with different names.

To be used when a metric is used in different modes such as real-time vs
screenshare (will be done in https://codereview.webrtc.org/1564923008/).

BUG=webrtc:5283

Committed: https://crrev.com/040b79ff7e4d5824a97ead0099d7ea84c2476c30
Cr-Commit-Position: refs/heads/master@{#11461}
==========

[commit-bot: I haz the power, 2016-02-02 15:13:28]

Patchset 4 (id:??) landed as
https://crrev.com/040b79ff7e4d5824a97ead0099d7ea84c2476c30
Cr-Commit-Position: refs/heads/master@{#11461}