Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issue 1566683002: Disable VideoCaptureTest.Capabilities and CreateDelete fails on Mac (Closed)

Created:
4 years, 11 months ago by kjellander_webrtc
Modified:
4 years, 11 months ago
Reviewers:
perkj_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, perkj_webrtc, mflodman, sdk-team_agora.io
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Disable VideoCaptureTest.Capabilities and CreateDelete fails on Mac These tests started failing on the bots after switching the build from 32 to 64-bit. NOTRY=True BUG=webrtc:5406 TBR=perkj@webrtc.org Committed: https://crrev.com/335ecf59d0397e976f6e86b81c7aef0b1277484e Cr-Commit-Position: refs/heads/master@{#11154}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -2 lines) Patch
M webrtc/modules/video_capture/test/video_capture_unittest.cc View 2 chunks +16 lines, -2 lines 1 comment Download

Messages

Total messages: 8 (4 generated)
kjellander_webrtc
https://codereview.webrtc.org/1566683002/diff/1/webrtc/modules/video_capture/test/video_capture_unittest.cc File webrtc/modules/video_capture/test/video_capture_unittest.cc (right): https://codereview.webrtc.org/1566683002/diff/1/webrtc/modules/video_capture/test/video_capture_unittest.cc#newcode330 webrtc/modules/video_capture/test/video_capture_unittest.cc:330: printf("Video capture capabilities are not supported on Mac.\n"); I ...
4 years, 11 months ago (2016-01-06 13:18:51 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1566683002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1566683002/1
4 years, 11 months ago (2016-01-06 13:19:27 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-06 13:23:14 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-06 13:23:25 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/335ecf59d0397e976f6e86b81c7aef0b1277484e
Cr-Commit-Position: refs/heads/master@{#11154}

Powered by Google App Engine
This is Rietveld 408576698