Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Issue 1566103003: Adding a way for a Java RtpSender to set a track without taking ownership. (Closed)

Created:
4 years, 11 months ago by Taylor Brandstetter
Modified:
4 years, 11 months ago
Reviewers:
AlexG, pthatcher1
CC:
webrtc-reviews_webrtc.org
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Adding a way for a Java RtpSender to set a track without taking ownership. This means that the track will still have a reference count after the PeerConnection and RtpSender have been destroyed. R=glaznev@webrtc.org, pthatcher@webrtc.org Committed: https://crrev.com/e5ba13bc09a17ada23e0ed6e6f0eb7f3476a1ed0 Cr-Commit-Position: refs/heads/master@{#11176}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -10 lines) Patch
M talk/app/webrtc/java/jni/peerconnection_jni.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M talk/app/webrtc/java/src/org/webrtc/RtpSender.java View 3 chunks +17 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Taylor Brandstetter
glaznev@: Please take a look. This is basically equivalent to "addPreservedTrack" on MediaStream, but I ...
4 years, 11 months ago (2016-01-07 18:23:14 UTC) #2
pthatcher1
lgtm
4 years, 11 months ago (2016-01-07 20:25:46 UTC) #3
AlexG
lgtm
4 years, 11 months ago (2016-01-07 20:34:24 UTC) #4
Taylor Brandstetter
Committed patchset #1 (id:1) manually as e5ba13bc09a17ada23e0ed6e6f0eb7f3476a1ed0 (presubmit successful).
4 years, 11 months ago (2016-01-07 23:11:38 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-07 23:11:42 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e5ba13bc09a17ada23e0ed6e6f0eb7f3476a1ed0
Cr-Commit-Position: refs/heads/master@{#11176}

Powered by Google App Engine
This is Rietveld 408576698