Fix bug 574524: DtlsTransportChannel crashes after SSL closes remotely

Fix bug 574524: DtlsTransportChannel crashes after SSL closes remotely

When remote side closes, opensslstreamadapter could return SR_EOS which will not trigger upper layer to clean up what's left in the StreamInterfaceChannel. The result of this is when there are more packets coming in, the Write on the StreamInterfaceChannel will overflow the buffer.

The fix here is that when receiving the remote side close signal, we also close the underneath StreamInterfaceChannel which will clean up the queue to prevent overflow.

BUG=574524
TBR=pthatcher@webrtc.org

Committed: https://crrev.com/4cc9f98e4c10741a28cd0c715e6c130cb30dbd0f
Cr-Commit-Position: refs/heads/master@{#11751}

[guoweis_webrtc, 2016-01-06 23:42:28]

Description was changed from

==========
fix dtls crash

BUG=
==========

to

==========
Fix bug 574524: DtlsTransportChannel crashes after SSL closes remotely

When remote side closes, opensslstreamadapter could return SR_EOS which will not
trigger upper layer to clean up what's left in the StreamInterfaceChannel. The
result of this is when there are more packets coming in, the Write on the
StreamInterfaceChannel will overflow the buffer.

The fix I have here is that when receiving the remote side close signal, we also
close the underneath StreamInterfaceChannel which will clean up the queue to
prevent overflow.

BUG=574524
==========

[guoweis_webrtc, 2016-01-06 23:42:39]

Description was changed from

==========
Fix bug 574524: DtlsTransportChannel crashes after SSL closes remotely

When remote side closes, opensslstreamadapter could return SR_EOS which will not
trigger upper layer to clean up what's left in the StreamInterfaceChannel. The
result of this is when there are more packets coming in, the Write on the
StreamInterfaceChannel will overflow the buffer.

The fix I have here is that when receiving the remote side close signal, we also
close the underneath StreamInterfaceChannel which will clean up the queue to
prevent overflow.

BUG=574524
==========

to

==========
Fix bug 574524: DtlsTransportChannel crashes after SSL closes remotely

When remote side closes, opensslstreamadapter could return SR_EOS which will not
trigger upper layer to clean up what's left in the StreamInterfaceChannel. The
result of this is when there are more packets coming in, the Write on the
StreamInterfaceChannel will overflow the buffer.

The fix here is that when receiving the remote side close signal, we also close
the underneath StreamInterfaceChannel which will clean up the queue to prevent
overflow.

BUG=574524
==========

[guoweis_webrtc, 2016-01-06 23:48:38]

guoweis@webrtc.org changed reviewers:
+ pthatcher@webrtc.org

[pthatcher2, 2016-02-17 23:20:29]

pthatcher@chromium.org changed reviewers:
+ pthatcher@chromium.org

[pthatcher2, 2016-02-17 23:20:29]

lgtm

Honghai, can you submit this?

[guoweis_webrtc, 2016-02-23 20:24:57]

The CQ bit was checked by guoweis@webrtc.org

[commit-bot: I haz the power, 2016-02-23 20:25:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1566023002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1566023002/20001

[commit-bot: I haz the power, 2016-02-23 20:29:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-23 20:29:50]

Try jobs failed on following builders:
  presubmit on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/3633)

[guoweis_webrtc, 2016-02-24 19:08:04]

Description was changed from

==========
Fix bug 574524: DtlsTransportChannel crashes after SSL closes remotely

When remote side closes, opensslstreamadapter could return SR_EOS which will not
trigger upper layer to clean up what's left in the StreamInterfaceChannel. The
result of this is when there are more packets coming in, the Write on the
StreamInterfaceChannel will overflow the buffer.

The fix here is that when receiving the remote side close signal, we also close
the underneath StreamInterfaceChannel which will clean up the queue to prevent
overflow.

BUG=574524
==========

to

==========
Fix bug 574524: DtlsTransportChannel crashes after SSL closes remotely

When remote side closes, opensslstreamadapter could return SR_EOS which will not
trigger upper layer to clean up what's left in the StreamInterfaceChannel. The
result of this is when there are more packets coming in, the Write on the
StreamInterfaceChannel will overflow the buffer.

The fix here is that when receiving the remote side close signal, we also close
the underneath StreamInterfaceChannel which will clean up the queue to prevent
overflow.

BUG=574524
TBR=pthatcher@webrtc.org
==========

[guoweis_webrtc, 2016-02-24 19:08:26]

The CQ bit was checked by guoweis@webrtc.org

[commit-bot: I haz the power, 2016-02-24 19:08:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1566023002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1566023002/20001

[commit-bot: I haz the power, 2016-02-24 19:10:09]

Description was changed from

==========
Fix bug 574524: DtlsTransportChannel crashes after SSL closes remotely

When remote side closes, opensslstreamadapter could return SR_EOS which will not
trigger upper layer to clean up what's left in the StreamInterfaceChannel. The
result of this is when there are more packets coming in, the Write on the
StreamInterfaceChannel will overflow the buffer.

The fix here is that when receiving the remote side close signal, we also close
the underneath StreamInterfaceChannel which will clean up the queue to prevent
overflow.

BUG=574524
TBR=pthatcher@webrtc.org
==========

to

==========
Fix bug 574524: DtlsTransportChannel crashes after SSL closes remotely

When remote side closes, opensslstreamadapter could return SR_EOS which will not
trigger upper layer to clean up what's left in the StreamInterfaceChannel. The
result of this is when there are more packets coming in, the Write on the
StreamInterfaceChannel will overflow the buffer.

The fix here is that when receiving the remote side close signal, we also close
the underneath StreamInterfaceChannel which will clean up the queue to prevent
overflow.

BUG=574524
TBR=pthatcher@webrtc.org
==========

[commit-bot: I haz the power, 2016-02-24 19:10:09]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-02-24 19:10:12]

Description was changed from

==========
Fix bug 574524: DtlsTransportChannel crashes after SSL closes remotely

When remote side closes, opensslstreamadapter could return SR_EOS which will not
trigger upper layer to clean up what's left in the StreamInterfaceChannel. The
result of this is when there are more packets coming in, the Write on the
StreamInterfaceChannel will overflow the buffer.

The fix here is that when receiving the remote side close signal, we also close
the underneath StreamInterfaceChannel which will clean up the queue to prevent
overflow.

BUG=574524
TBR=pthatcher@webrtc.org
==========

to

==========
Fix bug 574524: DtlsTransportChannel crashes after SSL closes remotely

When remote side closes, opensslstreamadapter could return SR_EOS which will not
trigger upper layer to clean up what's left in the StreamInterfaceChannel. The
result of this is when there are more packets coming in, the Write on the
StreamInterfaceChannel will overflow the buffer.

The fix here is that when receiving the remote side close signal, we also close
the underneath StreamInterfaceChannel which will clean up the queue to prevent
overflow.

BUG=574524
TBR=pthatcher@webrtc.org

Committed: https://crrev.com/4cc9f98e4c10741a28cd0c715e6c130cb30dbd0f
Cr-Commit-Position: refs/heads/master@{#11751}
==========

[commit-bot: I haz the power, 2016-02-24 19:10:13]

Patchset 2 (id:??) landed as
https://crrev.com/4cc9f98e4c10741a28cd0c715e6c130cb30dbd0f
Cr-Commit-Position: refs/heads/master@{#11751}