Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Unified Diff: webrtc/media/engine/webrtcvoiceengine.cc

Issue 1565133002: Remove the 'audioDebugRecording' media constraint and the aec_dump AudioOptions flag. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@wvoe_options
Patch Set: le rebase Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/media/base/mediachannel.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/media/engine/webrtcvoiceengine.cc
diff --git a/webrtc/media/engine/webrtcvoiceengine.cc b/webrtc/media/engine/webrtcvoiceengine.cc
index 70f7f3a4b4c5a79e93a3dde73ab1e9858701c054..3709e807d3ee40dad4b2976582066dda61e6f796 100644
--- a/webrtc/media/engine/webrtcvoiceengine.cc
+++ b/webrtc/media/engine/webrtcvoiceengine.cc
@@ -92,23 +92,6 @@ const int kOpusMaxBitrate = 510000;
// See also http://tools.ietf.org/html/draft-jennings-rtcweb-qos-00
const rtc::DiffServCodePoint kAudioDscpValue = rtc::DSCP_EF;
-// Ensure we open the file in a writeable path on ChromeOS and Android. This
-// workaround can be removed when it's possible to specify a filename for audio
-// option based AEC dumps.
-//
-// TODO(grunell): Use a string in the options instead of hardcoding it here
-// and let the embedder choose the filename (crbug.com/264223).
-//
-// NOTE(ajm): Don't use hardcoded paths on platforms not explicitly specified
-// below.
-#if defined(CHROMEOS)
-const char kAecDumpByAudioOptionFilename[] = "/tmp/audio.aecdump";
-#elif defined(ANDROID)
-const char kAecDumpByAudioOptionFilename[] = "/sdcard/audio.aecdump";
-#else
-const char kAecDumpByAudioOptionFilename[] = "audio.aecdump";
-#endif
-
// Constants from voice_engine_defines.h.
const int kMinTelephoneEventCode = 0; // RFC4733 (Section 2.3.1)
const int kMaxTelephoneEventCode = 255;
@@ -615,7 +598,6 @@ bool WebRtcVoiceEngine::InitInternal() {
options.extended_filter_aec = rtc::Optional<bool>(false);
options.delay_agnostic_aec = rtc::Optional<bool>(false);
options.experimental_ns = rtc::Optional<bool>(false);
- options.aec_dump = rtc::Optional<bool>(false);
if (!ApplyOptions(options)) {
return false;
}
@@ -868,14 +850,6 @@ bool WebRtcVoiceEngine::ApplyOptions(const AudioOptions& options_in) {
}
}
- if (options.aec_dump) {
- LOG(LS_INFO) << "Aec dump is enabled? " << *options.aec_dump;
- if (*options.aec_dump)
- StartAecDump(kAecDumpByAudioOptionFilename);
- else
- StopAecDump();
- }
-
webrtc::Config config;
if (options.delay_agnostic_aec)
« no previous file with comments | « webrtc/media/base/mediachannel.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698