webrtc/system_wrappers/include/metrics.h - Issue 1564923008: Integrate helper macros for calling histograms with different names (real-time vs screenshare and r…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/system_wrappers/include/metrics.h

Issue 1564923008: Integrate helper macros for calling histograms with different names (real-time vs screenshare and r… (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/modules/bitrate_controller/send_side_bandwidth_estimation.cc ('k') | webrtc/system_wrappers/source/metrics_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/system_wrappers/include/metrics.h

diff --git a/webrtc/system_wrappers/include/metrics.h b/webrtc/system_wrappers/include/metrics.h

index ce193bdc39bc897bc10431ffff2ba27075267718..f4564a19b3da143ee4f4790fa6b1fa342804e783 100644

--- a/webrtc/system_wrappers/include/metrics.h

+++ b/webrtc/system_wrappers/include/metrics.h

@@ -187,8 +187,7 @@

#define RTC_HISTOGRAMS_COMMON(index, name, sample, macro_invocation) \

do { \

- RTC_DCHECK(index >= 0); \

- RTC_DCHECK(index <= 2); \

+ RTC_DCHECK_LE(index, 2u); \

switch (index) { \

case 0: \

macro_invocation; \