Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issue 1563983003: Cleaning neteq_unittest resource files. (Closed)

Created:
4 years, 11 months ago by minyue-webrtc
Modified:
4 years, 11 months ago
CC:
webrtc-reviews_webrtc.org, kwiberg-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Cleaning neteq_unittest resource files. BUG=webrtc:2692 Committed: https://crrev.com/49c454e748ce89c195b2440b5f194ddb706d949b Cr-Commit-Position: refs/heads/master@{#11189}

Patch Set 1 #

Patch Set 2 : isolate and two more files #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -10 lines) Patch
D resources/audio_coding/neteq_network_stats.dat.sha1 View 1 1 chunk +0 lines, -1 line 0 comments Download
D resources/audio_coding/neteq_network_stats_win_32.dat.sha1 View 1 1 chunk +0 lines, -1 line 0 comments Download
D resources/audio_coding/neteq_rtcp_stats.dat.sha1 View 1 chunk +0 lines, -1 line 0 comments Download
D resources/audio_coding/neteq_universal_ref.pcm.sha1 View 1 chunk +0 lines, -1 line 0 comments Download
D resources/audio_coding/neteq_universal_ref_win_32.pcm.sha1 View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/audio_coding/neteq/neteq_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/modules_unittests.isolate View 1 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 30 (14 generated)
minyue-webrtc
Hi Henrik, some further clean up of neteq_unittest. Would you review it?
4 years, 11 months ago (2016-01-07 17:02:38 UTC) #2
hlundin-webrtc
lgtm, but please clean up webrtc/modules/modules_unittests.isolate too. That file mentions some of the deleted files. ...
4 years, 11 months ago (2016-01-08 12:26:09 UTC) #3
minyue-webrtc
Thanks. I have updated the isolation file. From there, I also found two more files ...
4 years, 11 months ago (2016-01-08 12:46:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1563983003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1563983003/20001
4 years, 11 months ago (2016-01-08 13:03:36 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/2746)
4 years, 11 months ago (2016-01-08 13:09:44 UTC) #9
minyue-webrtc
On 2016/01/08 13:09:44, commit-bot: I haz the power wrote: > Try jobs failed on following ...
4 years, 11 months ago (2016-01-08 14:04:34 UTC) #12
kjellander_webrtc
lgtm. No BUG= reference available?
4 years, 11 months ago (2016-01-08 14:10:38 UTC) #13
minyue-webrtc
On 2016/01/08 14:10:38, kjellander (webrtc) wrote: > lgtm. No BUG= reference available? maybe good to ...
4 years, 11 months ago (2016-01-08 16:19:03 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1563983003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1563983003/20001
4 years, 11 months ago (2016-01-08 16:19:27 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: mac_baremetal on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/mac_baremetal/builds/8336)
4 years, 11 months ago (2016-01-08 17:40:49 UTC) #19
kjellander_webrtc
On 2016/01/08 17:40:49, commit-bot: I haz the power wrote: > Try jobs failed on following ...
4 years, 11 months ago (2016-01-08 18:35:38 UTC) #20
kjellander_webrtc
On 2016/01/08 18:35:38, kjellander (webrtc) wrote: > On 2016/01/08 17:40:49, commit-bot: I haz the power ...
4 years, 11 months ago (2016-01-08 18:42:36 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1563983003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1563983003/20001
4 years, 11 months ago (2016-01-08 18:42:48 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1563983003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1563983003/20001
4 years, 11 months ago (2016-01-08 18:50:39 UTC) #26
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-08 19:30:18 UTC) #28
commit-bot: I haz the power
4 years, 11 months ago (2016-01-08 19:30:25 UTC) #30
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/49c454e748ce89c195b2440b5f194ddb706d949b
Cr-Commit-Position: refs/heads/master@{#11189}

Powered by Google App Engine
This is Rietveld 408576698