Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Unified Diff: webrtc/modules/audio_processing/audio_processing_impl.cc

Issue 1563493005: Make Beamforming dynamically settable for Android platform builds (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Re-add num_out_channels > 1 restriction Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/modules/audio_processing/audio_processing_impl.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/modules/audio_processing/audio_processing_impl.cc
diff --git a/webrtc/modules/audio_processing/audio_processing_impl.cc b/webrtc/modules/audio_processing/audio_processing_impl.cc
index c0c5e8a4659bed6ff9ddbfe01dbfcfba9c832ebf..67709b215fc9074e84c869c6e145491dcae8d713 100644
--- a/webrtc/modules/audio_processing/audio_processing_impl.cc
+++ b/webrtc/modules/audio_processing/audio_processing_impl.cc
@@ -214,21 +214,21 @@ AudioProcessingImpl::AudioProcessingImpl(const Config& config,
: public_submodules_(new ApmPublicSubmodules()),
private_submodules_(new ApmPrivateSubmodules(beamformer)),
constants_(config.Get<ExperimentalAgc>().startup_min_volume,
- config.Get<Beamforming>().array_geometry,
- config.Get<Beamforming>().target_direction,
#if defined(WEBRTC_ANDROID) || defined(WEBRTC_IOS)
false,
#else
config.Get<ExperimentalAgc>().enabled,
#endif
- config.Get<Intelligibility>().enabled,
- config.Get<Beamforming>().enabled),
+ config.Get<Intelligibility>().enabled),
#if defined(WEBRTC_ANDROID) || defined(WEBRTC_IOS)
- capture_(false)
+ capture_(false,
#else
- capture_(config.Get<ExperimentalNs>().enabled)
+ capture_(config.Get<ExperimentalNs>().enabled,
#endif
+ config.Get<Beamforming>().enabled,
+ config.Get<Beamforming>().array_geometry,
+ config.Get<Beamforming>().target_direction)
{
{
rtc::CritScope cs_render(&crit_render_);
@@ -345,7 +345,7 @@ int AudioProcessingImpl::MaybeInitialize(
int AudioProcessingImpl::InitializeLocked() {
const int fwd_audio_buffer_channels =
- constants_.beamformer_enabled
+ capture_.beamformer_enabled
? formats_.api_format.input_stream().num_channels()
: formats_.api_format.output_stream().num_channels();
const int rev_audio_buffer_out_num_frames =
@@ -428,9 +428,9 @@ int AudioProcessingImpl::InitializeLocked(const ProcessingConfig& config) {
return kBadNumberChannelsError;
}
- if (constants_.beamformer_enabled && (static_cast<size_t>(num_in_channels) !=
- constants_.array_geometry.size() ||
- num_out_channels > 1)) {
+ if (capture_.beamformer_enabled &&
+ (static_cast<size_t>(num_in_channels) != capture_.array_geometry.size() ||
+ num_out_channels > 1)) {
return kBadNumberChannelsError;
}
@@ -498,6 +498,17 @@ void AudioProcessingImpl::SetExtraOptions(const Config& config) {
config.Get<ExperimentalNs>().enabled;
InitializeTransient();
}
+
+#ifdef WEBRTC_ANDROID_PLATFORM_BUILD
+ if (capture_.beamformer_enabled != config.Get<Beamforming>().enabled) {
+ capture_.beamformer_enabled = config.Get<Beamforming>().enabled;
+ if (config.Get<Beamforming>().array_geometry.size() > 1) {
+ capture_.array_geometry = config.Get<Beamforming>().array_geometry;
+ }
+ capture_.target_direction = config.Get<Beamforming>().target_direction;
+ InitializeBeamformer();
+ }
+#endif // WEBRTC_ANDROID_PLATFORM_BUILD
}
int AudioProcessingImpl::input_sample_rate_hz() const {
@@ -760,7 +771,7 @@ int AudioProcessingImpl::ProcessStreamLocked() {
ca->num_channels());
}
- if (constants_.beamformer_enabled) {
+ if (capture_.beamformer_enabled) {
private_submodules_->beamformer->ProcessChunk(*ca->split_data_f(),
ca->split_data_f());
ca->set_num_channels(1);
@@ -782,7 +793,7 @@ int AudioProcessingImpl::ProcessStreamLocked() {
if (constants_.use_new_agc &&
public_submodules_->gain_control->is_enabled() &&
- (!constants_.beamformer_enabled ||
+ (!capture_.beamformer_enabled ||
private_submodules_->beamformer->is_target_present())) {
private_submodules_->agc_manager->Process(
ca->split_bands_const(0)[kBand0To8kHz], ca->num_frames_per_band(),
@@ -1172,7 +1183,7 @@ VoiceDetection* AudioProcessingImpl::voice_detection() const {
}
bool AudioProcessingImpl::is_data_processed() const {
- if (constants_.beamformer_enabled) {
+ if (capture_.beamformer_enabled) {
return true;
}
@@ -1287,10 +1298,10 @@ void AudioProcessingImpl::InitializeTransient() {
}
void AudioProcessingImpl::InitializeBeamformer() {
- if (constants_.beamformer_enabled) {
+ if (capture_.beamformer_enabled) {
if (!private_submodules_->beamformer) {
private_submodules_->beamformer.reset(new NonlinearBeamformer(
- constants_.array_geometry, constants_.target_direction));
+ capture_.array_geometry, capture_.target_direction));
}
private_submodules_->beamformer->Initialize(kChunkSizeMs,
capture_nonlocked_.split_rate);
« no previous file with comments | « webrtc/modules/audio_processing/audio_processing_impl.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698