Make Beamforming dynamically settable for Android platform builds

Make Beamforming dynamically settable for Android platform builds

Committed: https://crrev.com/2a34688f86517bfd3745e131e4e5d2b7a924f46a
Cr-Commit-Position: refs/heads/master@{#11213}

[aluebs-webrtc, 2016-01-05 22:49:48]

aluebs@webrtc.org changed reviewers:
+ henrik.lundin@webrtc.org

[hlundin-webrtc, 2016-01-08 12:38:39]

https://codereview.webrtc.org/1563493005/diff/1/webrtc/modules/audio_processi...
File webrtc/modules/audio_processing/audio_processing_impl.cc (right):

https://codereview.webrtc.org/1563493005/diff/1/webrtc/modules/audio_processi...
webrtc/modules/audio_processing/audio_processing_impl.cc:432:
static_cast<size_t>(num_in_channels) != capture_.array_geometry.size()) {
What happened to num_out_channels > 1?

https://codereview.webrtc.org/1563493005/diff/1/webrtc/modules/audio_processi...
webrtc/modules/audio_processing/audio_processing_impl.cc:501: #ifdef
WEBRTC_ANDROID_PLATFORM_BUILD
Why not WEBRTC_ANDROID?

https://codereview.webrtc.org/1563493005/diff/1/webrtc/modules/audio_processi...
webrtc/modules/audio_processing/audio_processing_impl.cc:510: #endif  //
WEBRTC_AUDIOPROC_DEBUG_DUMP
Wrong comment.

https://codereview.webrtc.org/1563493005/diff/1/webrtc/modules/audio_processi...
File webrtc/modules/audio_processing/audio_processing_impl.h (right):

https://codereview.webrtc.org/1563493005/diff/1/webrtc/modules/audio_processi...
webrtc/modules/audio_processing/audio_processing_impl.h:284: const
std::vector<Point> array_geometry,
Can't this be a const reference? Otherwise the const qualifier is a but
unnecessary.

[aluebs-webrtc, 2016-01-08 17:59:18]

https://codereview.webrtc.org/1563493005/diff/1/webrtc/modules/audio_processi...
File webrtc/modules/audio_processing/audio_processing_impl.cc (right):

https://codereview.webrtc.org/1563493005/diff/1/webrtc/modules/audio_processi...
webrtc/modules/audio_processing/audio_processing_impl.cc:432:
static_cast<size_t>(num_in_channels) != capture_.array_geometry.size()) {
On 2016/01/08 12:38:38, hlundin-webrtc wrote:
> What happened to num_out_channels > 1?

I thought this was a fictitious restriction, since we upmix in InterleaveTo, but
I just realized we don't in CopyTo, so it actually is a restriction for the
float interface. I am adding it back here and will do a new CL for that.

https://codereview.webrtc.org/1563493005/diff/1/webrtc/modules/audio_processi...
webrtc/modules/audio_processing/audio_processing_impl.cc:501: #ifdef
WEBRTC_ANDROID_PLATFORM_BUILD
On 2016/01/08 12:38:38, hlundin-webrtc wrote:
> Why not WEBRTC_ANDROID?

Because I want to be as restrictive as possible and that is only for an android
platform build.

https://codereview.webrtc.org/1563493005/diff/1/webrtc/modules/audio_processi...
webrtc/modules/audio_processing/audio_processing_impl.cc:510: #endif  //
WEBRTC_AUDIOPROC_DEBUG_DUMP
On 2016/01/08 12:38:38, hlundin-webrtc wrote:
> Wrong comment.

Done.

https://codereview.webrtc.org/1563493005/diff/1/webrtc/modules/audio_processi...
File webrtc/modules/audio_processing/audio_processing_impl.h (right):

https://codereview.webrtc.org/1563493005/diff/1/webrtc/modules/audio_processi...
webrtc/modules/audio_processing/audio_processing_impl.h:284: const
std::vector<Point> array_geometry,
On 2016/01/08 12:38:39, hlundin-webrtc wrote:
> Can't this be a const reference? Otherwise the const qualifier is a but
> unnecessary.

Great point! Copying and pasting is a hard task... :)

[hlundin-webrtc, 2016-01-11 16:00:42]

lgtm

https://codereview.webrtc.org/1563493005/diff/1/webrtc/modules/audio_processi...
File webrtc/modules/audio_processing/audio_processing_impl.cc (right):

https://codereview.webrtc.org/1563493005/diff/1/webrtc/modules/audio_processi...
webrtc/modules/audio_processing/audio_processing_impl.cc:501: #ifdef
WEBRTC_ANDROID_PLATFORM_BUILD
On 2016/01/08 17:59:17, aluebs-webrtc wrote:
> On 2016/01/08 12:38:38, hlundin-webrtc wrote:
> > Why not WEBRTC_ANDROID?
> 
> Because I want to be as restrictive as possible and that is only for an
android
> platform build.

Acknowledged.

[aluebs-webrtc, 2016-01-11 17:11:27]

The CQ bit was checked by aluebs@webrtc.org

[commit-bot: I haz the power, 2016-01-11 17:11:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1563493005/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1563493005/20001

[commit-bot: I haz the power, 2016-01-11 17:15:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-11 17:15:15]

Try jobs failed on following builders:
  mac_baremetal on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_baremetal/builds/8373)

[aluebs-webrtc, 2016-01-12 01:43:04]

The CQ bit was checked by aluebs@webrtc.org

[commit-bot: I haz the power, 2016-01-12 01:43:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1563493005/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1563493005/20001

[commit-bot: I haz the power, 2016-01-12 02:04:34]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-01-12 02:04:39]

Description was changed from

==========
Make Beamforming dynamically settable for Android platform builds
==========

to

==========
Make Beamforming dynamically settable for Android platform builds

Committed: https://crrev.com/2a34688f86517bfd3745e131e4e5d2b7a924f46a
Cr-Commit-Position: refs/heads/master@{#11213}
==========

[commit-bot: I haz the power, 2016-01-12 02:04:40]

Patchset 2 (id:??) landed as
https://crrev.com/2a34688f86517bfd3745e131e4e5d2b7a924f46a
Cr-Commit-Position: refs/heads/master@{#11213}