Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 1561073005: Fix clang warning in peerconnection_jni.cc (Closed)

Created:
4 years, 11 months ago by perkj_webrtc
Modified:
4 years, 11 months ago
CC:
webrtc-reviews_webrtc.org
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix clang warning in peerconnection_jni.cc TEST= export GYP_DEFINES="OS=android clang=1" ... ninja -C out/Debug AppRTCDemo BUG=webrtc:5399 Committed: https://crrev.com/fbeb97e01f02a528cce02f076942a779195270a5 Cr-Commit-Position: refs/heads/master@{#11181}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -10 lines) Patch
M talk/app/webrtc/java/jni/peerconnection_jni.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M talk/libjingle.gyp View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
perkj_webrtc
please?
4 years, 11 months ago (2016-01-07 12:33:38 UTC) #3
kjellander_webrtc
Awesome, lgtm!
4 years, 11 months ago (2016-01-07 12:46:22 UTC) #4
magjed_webrtc
lgtm
4 years, 11 months ago (2016-01-08 08:41:56 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1561073005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1561073005/1
4 years, 11 months ago (2016-01-08 08:42:10 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-08 08:43:11 UTC) #9
commit-bot: I haz the power
4 years, 11 months ago (2016-01-08 08:43:23 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fbeb97e01f02a528cce02f076942a779195270a5
Cr-Commit-Position: refs/heads/master@{#11181}

Powered by Google App Engine
This is Rietveld 408576698