Update API for Objective-C RTCPeerConnectionFactory.

Update API for Objective-C RTCPeerConnectionFactory.

BUG=
R=jiayl@webrtc.org, tkchin@webrtc.org

Committed: https://crrev.com/da99da81c928765ddf4f1ef17f13b9897c3d23b5
Patch from Jon Hjelle <hjon@andyet.net>;.

Cr-Commit-Position: refs/heads/master@{#11326}

[hjon, 2015-12-31 00:15:51]

hjon@andyet.net changed reviewers:
+ tkchin@webrtc.org

[hjon, 2015-12-31 00:15:51]

tkchin@ From what I can see, we still need this as a means for initializing SSL
and passing the native factory around for initializers that need it. Is that how
you see it, too, or did you have something else in mind?

[tkchin_webrtc, 2016-01-06 22:25:15]

https://codereview.webrtc.org/1558473002/diff/1/webrtc/api/objc/RTCPeerConnec...
File webrtc/api/objc/RTCPeerConnectionFactory+Private.h (right):

https://codereview.webrtc.org/1558473002/diff/1/webrtc/api/objc/RTCPeerConnec...
webrtc/api/objc/RTCPeerConnectionFactory+Private.h:21: *
PeerConnectionFactoryInterface representation of this
update comment.

https://codereview.webrtc.org/1558473002/diff/1/webrtc/api/objc/RTCPeerConnec...
File webrtc/api/objc/RTCPeerConnectionFactory.h (right):

https://codereview.webrtc.org/1558473002/diff/1/webrtc/api/objc/RTCPeerConnec...
webrtc/api/objc/RTCPeerConnectionFactory.h:17: /** Initialize & de-initialize
the SSL subsystem. Failure is fatal. */
library not subsystem. These may make more sense in an RTCSSLAdapter.h file. 
Add comments that point at ssladapter.h, and add these methods:

BOOL RTCInitializeSSL();
BOOL RTCCleanupSSL();

In the implementation file just call the relevant C method from ssladapter.h.

[hjon, 2016-01-08 01:01:06]

https://codereview.webrtc.org/1558473002/diff/1/webrtc/api/objc/RTCPeerConnec...
File webrtc/api/objc/RTCPeerConnectionFactory+Private.h (right):

https://codereview.webrtc.org/1558473002/diff/1/webrtc/api/objc/RTCPeerConnec...
webrtc/api/objc/RTCPeerConnectionFactory+Private.h:21: *
PeerConnectionFactoryInterface representation of this
On 2016/01/06 22:25:15, tkchin_webrtc wrote:
> update comment. 

Done.

https://codereview.webrtc.org/1558473002/diff/1/webrtc/api/objc/RTCPeerConnec...
File webrtc/api/objc/RTCPeerConnectionFactory.h (right):

https://codereview.webrtc.org/1558473002/diff/1/webrtc/api/objc/RTCPeerConnec...
webrtc/api/objc/RTCPeerConnectionFactory.h:17: /** Initialize & de-initialize
the SSL subsystem. Failure is fatal. */
On 2016/01/06 22:25:15, tkchin_webrtc wrote:
> library not subsystem. These may make more sense in an RTCSSLAdapter.h file. 
> Add comments that point at ssladapter.h, and add these methods:
> 
> BOOL RTCInitializeSSL();
> BOOL RTCCleanupSSL();
> 
> In the implementation file just call the relevant C method from ssladapter.h.

Done.

[tkchin_webrtc, 2016-01-14 01:38:52]

On 2016/01/13 19:04:27, hjon wrote:

lgtm

[tkchin_webrtc, 2016-01-14 01:40:13]

On 2016/01/14 01:38:52, tkchin_webrtc wrote:
> On 2016/01/13 19:04:27, hjon wrote:
> 
> lgtm

If I understand the cookie situation correctly - would you be able to see if you
can commit this with "git cl land"?
Make sure to set your git email to hjon@webrtc.org though!

[tkchin_webrtc, 2016-01-14 01:46:21]

https://codereview.webrtc.org/1558473002/diff/100001/webrtc/api/objc/RTCPeerC...
File webrtc/api/objc/RTCPeerConnectionFactory.h (right):

https://codereview.webrtc.org/1558473002/diff/100001/webrtc/api/objc/RTCPeerC...
webrtc/api/objc/RTCPeerConnectionFactory.h:16: 
nit: remove blank line

https://codereview.webrtc.org/1558473002/diff/100001/webrtc/base/objc/RTCSSLA...
File webrtc/base/objc/RTCSSLAdapter.h (right):

https://codereview.webrtc.org/1558473002/diff/100001/webrtc/base/objc/RTCSSLA...
webrtc/base/objc/RTCSSLAdapter.h:14: * Initialize & clean up the SSL library.
Failure is fatal. These call the
nit: and instead of &

[hjon, 2016-01-14 18:28:25]

On 2016/01/14 01:40:13, tkchin_webrtc wrote:
> On 2016/01/14 01:38:52, tkchin_webrtc wrote:
> > On 2016/01/13 19:04:27, hjon wrote:
> > 
> > lgtm
> 
> If I understand the cookie situation correctly - would you be able to see if
you
> can commit this with "git cl land"?
> Make sure to set your git email to mailto:hjon@webrtc.org though!

The following is the output I received from "git cl land":

Using 50% similarity for rename/copy detection. Override with --similarity.
Running presubmit commit checks ...

** Presubmit Messages **
As you're changing GYP files: please make sure corresponding BUILD.gn files are
also updated.
Changed GYP files:
  webrtc/api/api.gyp \
  webrtc/base/base.gyp

If this change has an associated bug, add BUG=[bug number].

If this change requires manual test instructions to QA team, add
TEST=[instructions].

** Presubmit ERRORS **
Missing LGTM from an OWNER for these files:
    webrtc/base/BUILD.gn

Presubmit checks took 1.3s to calculate.

[hjon, 2016-01-14 18:28:34]

https://codereview.webrtc.org/1558473002/diff/100001/webrtc/api/objc/RTCPeerC...
File webrtc/api/objc/RTCPeerConnectionFactory.h (right):

https://codereview.webrtc.org/1558473002/diff/100001/webrtc/api/objc/RTCPeerC...
webrtc/api/objc/RTCPeerConnectionFactory.h:16: 
On 2016/01/14 01:46:21, tkchin_webrtc wrote:
> nit: remove blank line

Done.

https://codereview.webrtc.org/1558473002/diff/100001/webrtc/base/objc/RTCSSLA...
File webrtc/base/objc/RTCSSLAdapter.h (right):

https://codereview.webrtc.org/1558473002/diff/100001/webrtc/base/objc/RTCSSLA...
webrtc/base/objc/RTCSSLAdapter.h:14: * Initialize & clean up the SSL library.
Failure is fatal. These call the
On 2016/01/14 01:46:21, tkchin_webrtc wrote:
> nit: and instead of &

Done.

[tkchin_webrtc, 2016-01-20 21:12:11]

Description was changed from

==========
Update API for Objective-C RTCPeerConnectionFactory.

BUG=
==========

to

==========
Update API for Objective-C RTCPeerConnectionFactory.

BUG=
==========

[tkchin_webrtc, 2016-01-20 21:12:11]

tkchin@webrtc.org changed reviewers:
+ jiayl@webrtc.org

[tkchin_webrtc, 2016-01-20 21:12:59]

jiayl@ mind rubber stamping for webrtc/base?

[jiayl2, 2016-01-20 21:14:34]

lgtm

[tkchin_webrtc, 2016-01-20 21:40:39]

Description was changed from

==========
Update API for Objective-C RTCPeerConnectionFactory.

BUG=
==========

to

==========
Update API for Objective-C RTCPeerConnectionFactory.

BUG=
R=jiayl@webrtc.org, tkchin@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/da99da81c928765ddf4f1ef17...
==========

[commit-bot: I haz the power, 2016-01-20 21:40:40]

Description was changed from

==========
Update API for Objective-C RTCPeerConnectionFactory.

BUG=
R=jiayl@webrtc.org, tkchin@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/da99da81c928765ddf4f1ef17...
==========

to

==========
Update API for Objective-C RTCPeerConnectionFactory.

BUG=
R=jiayl@webrtc.org, tkchin@webrtc.org

Committed: https://crrev.com/da99da81c928765ddf4f1ef17f13b9897c3d23b5
Patch from Jon Hjelle <hjon@andyet.net>.

Cr-Commit-Position: refs/heads/master@{#11326}
==========

[tkchin_webrtc, 2016-01-20 21:40:41]

Committed patchset #9 (id:160001) manually as
da99da81c928765ddf4f1ef17f13b9897c3d23b5 (presubmit successful).

[commit-bot: I haz the power, 2016-01-20 21:40:41]

Patchset 9 (id:??) landed as
https://crrev.com/da99da81c928765ddf4f1ef17f13b9897c3d23b5
Cr-Commit-Position: refs/heads/master@{#11326}