Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1558453002: Move RTCFileLogger to webrtc/base/objc. (Closed)

Created:
4 years, 11 months ago by hjon
Modified:
4 years, 8 months ago
Reviewers:
tkchin_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Move RTCFileLogger to webrtc/base/objc. BUG=

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix file name #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -50 lines) Patch
M webrtc/base/BUILD.gn View 1 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/base/base.gyp View 1 1 chunk +2 lines, -0 lines 0 comments Download
A + webrtc/base/objc/RTCFileLogger.h View 2 chunks +9 lines, -27 lines 0 comments Download
A + webrtc/base/objc/RTCFileLogger.mm View 1 chunk +6 lines, -23 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
hjon
4 years, 11 months ago (2015-12-30 23:52:39 UTC) #2
tkchin_webrtc
https://codereview.webrtc.org/1558453002/diff/1/webrtc/base/BUILD.gn File webrtc/base/BUILD.gn (right): https://codereview.webrtc.org/1558453002/diff/1/webrtc/base/BUILD.gn#newcode628 webrtc/base/BUILD.gn:628: "objc/RTCLogger.h", RTCFileLogger
4 years, 11 months ago (2016-01-06 20:09:20 UTC) #3
tkchin_webrtc
lgtm
4 years, 11 months ago (2016-01-06 20:50:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1558453002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1558453002/20001
4 years, 11 months ago (2016-01-06 20:52:10 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-06 20:57:32 UTC) #8 
Try jobs failed on following builders:
  ios_arm64_rel on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_arm64_rel/builds/6576)

Powered by Google App Engine
This is Rietveld 408576698