[rtp_rtcp] rtcp::ExtenededReports packet got Parse function

rtcp::ExtenededReports packet class got Parse function

BUG=webrtc:5260
R=åsapersson

Committed: https://crrev.com/de13882d9471bf18709e52fa9a9eac1378b359be
Cr-Commit-Position: refs/heads/master@{#11428}

[danilchap, 2016-01-26 13:33:51]

Description was changed from

==========
[rtp_rtcp] rtcp::Xr packet moved into own file and got Parse function

renamed to rtcp::ExtenededReports on the way

BUG=webrtc:5260
R=åsapersson
==========

to

==========
BUG=webrtc:5260
R=åsapersson
==========

[åsapersson, 2016-01-29 12:46:09]

https://codereview.webrtc.org/1557593002/diff/80001/webrtc/modules/rtp_rtcp/s...
File webrtc/modules/rtp_rtcp/source/rtcp_packet/extended_reports.cc (right):

https://codereview.webrtc.org/1557593002/diff/80001/webrtc/modules/rtp_rtcp/s...
webrtc/modules/rtp_rtcp/source/rtcp_packet/extended_reports.cc:35: // Report
header:
maybe Report block header:

https://codereview.webrtc.org/1557593002/diff/80001/webrtc/modules/rtp_rtcp/s...
webrtc/modules/rtp_rtcp/source/rtcp_packet/extended_reports.cc:54: 
should the blocks be resized to zero here?

https://codereview.webrtc.org/1557593002/diff/80001/webrtc/modules/rtp_rtcp/s...
webrtc/modules/rtp_rtcp/source/rtcp_packet/extended_reports.cc:60: uint16_t
block_size =
perhaps call block_length (as in figure)

https://codereview.webrtc.org/1557593002/diff/80001/webrtc/modules/rtp_rtcp/s...
File webrtc/modules/rtp_rtcp/source/rtcp_packet/extended_reports.h (right):

https://codereview.webrtc.org/1557593002/diff/80001/webrtc/modules/rtp_rtcp/s...
webrtc/modules/rtp_rtcp/source/rtcp_packet/extended_reports.h:61: static const
size_t kXrHeaderLength = 4;
maybe kXrBaseLength (since xr header is 8 bytes).

https://codereview.webrtc.org/1557593002/diff/80001/webrtc/modules/rtp_rtcp/s...
File webrtc/modules/rtp_rtcp/source/rtcp_packet/extended_reports_unittest.cc
(right):

https://codereview.webrtc.org/1557593002/diff/80001/webrtc/modules/rtp_rtcp/s...
webrtc/modules/rtp_rtcp/source/rtcp_packet/extended_reports_unittest.cc:182:
TEST_F(RtcpPacketExtendedReportsTest, CreateAndParseWithRrtr) {
maybe CreateAndParseWithOneRrtrBlock

[danilchap, 2016-01-29 13:49:31]

https://codereview.webrtc.org/1557593002/diff/80001/webrtc/modules/rtp_rtcp/s...
File webrtc/modules/rtp_rtcp/source/rtcp_packet/extended_reports.cc (right):

https://codereview.webrtc.org/1557593002/diff/80001/webrtc/modules/rtp_rtcp/s...
webrtc/modules/rtp_rtcp/source/rtcp_packet/extended_reports.cc:35: // Report
header:
On 2016/01/29 12:46:09, åsapersson wrote:
> maybe Report block header:

To match specification included full report block instead of just it's header.

https://codereview.webrtc.org/1557593002/diff/80001/webrtc/modules/rtp_rtcp/s...
webrtc/modules/rtp_rtcp/source/rtcp_packet/extended_reports.cc:54: 
On 2016/01/29 12:46:09, åsapersson wrote:
> should the blocks be resized to zero here?

Done.

https://codereview.webrtc.org/1557593002/diff/80001/webrtc/modules/rtp_rtcp/s...
webrtc/modules/rtp_rtcp/source/rtcp_packet/extended_reports.cc:60: uint16_t
block_size =
On 2016/01/29 12:46:09, åsapersson wrote:
> perhaps call block_length (as in figure)

Done. Word 'size' may also give false impression it measure bytes.

https://codereview.webrtc.org/1557593002/diff/80001/webrtc/modules/rtp_rtcp/s...
File webrtc/modules/rtp_rtcp/source/rtcp_packet/extended_reports.h (right):

https://codereview.webrtc.org/1557593002/diff/80001/webrtc/modules/rtp_rtcp/s...
webrtc/modules/rtp_rtcp/source/rtcp_packet/extended_reports.h:61: static const
size_t kXrHeaderLength = 4;
On 2016/01/29 12:46:09, åsapersson wrote:
> maybe kXrBaseLength (since xr header is 8 bytes).

Done. My understanding where XR header starts didn't agree with specification.
Understanding fixed.

https://codereview.webrtc.org/1557593002/diff/80001/webrtc/modules/rtp_rtcp/s...
File webrtc/modules/rtp_rtcp/source/rtcp_packet/extended_reports_unittest.cc
(right):

https://codereview.webrtc.org/1557593002/diff/80001/webrtc/modules/rtp_rtcp/s...
webrtc/modules/rtp_rtcp/source/rtcp_packet/extended_reports_unittest.cc:182:
TEST_F(RtcpPacketExtendedReportsTest, CreateAndParseWithRrtr) {
On 2016/01/29 12:46:09, åsapersson wrote:
> maybe CreateAndParseWithOneRrtrBlock

Done.

[åsapersson, 2016-01-29 14:23:32]

lgtm

[danilchap, 2016-01-29 15:13:28]

The CQ bit was checked by danilchap@webrtc.org

[commit-bot: I haz the power, 2016-01-29 15:13:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1557593002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1557593002/100001

[commit-bot: I haz the power, 2016-01-29 15:27:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-29 15:27:54]

Exceeded global retry quota

[danilchap, 2016-01-29 16:39:58]

Description was changed from

==========
BUG=webrtc:5260
R=åsapersson
==========

to

==========
rtcp::ExtenededReports packet class got Parse function

BUG=webrtc:5260
R=åsapersson
==========

[danilchap, 2016-01-29 17:25:33]

The CQ bit was checked by danilchap@webrtc.org

[danilchap, 2016-01-29 17:25:34]

The patchset sent to the CQ was uploaded after l-g-t-m from
asapersson@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1557593002/#ps120001 (title:
"rebase & fix win compile errors")

[commit-bot: I haz the power, 2016-01-29 17:25:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1557593002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1557593002/120001

[commit-bot: I haz the power, 2016-01-29 17:33:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-29 17:33:48]

Try jobs failed on following builders:
  linux_libfuzzer_rel on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_libfuzzer_rel/bui...)

[danilchap, 2016-01-29 19:24:56]

The CQ bit was checked by danilchap@webrtc.org

[commit-bot: I haz the power, 2016-01-29 19:25:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1557593002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1557593002/120001

[commit-bot: I haz the power, 2016-01-29 19:26:20]

Description was changed from

==========
rtcp::ExtenededReports packet class got Parse function

BUG=webrtc:5260
R=åsapersson
==========

to

==========
rtcp::ExtenededReports packet class got Parse function

BUG=webrtc:5260
R=åsapersson
==========

[commit-bot: I haz the power, 2016-01-29 19:26:21]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-01-29 19:26:27]

Description was changed from

==========
rtcp::ExtenededReports packet class got Parse function

BUG=webrtc:5260
R=åsapersson
==========

to

==========
rtcp::ExtenededReports packet class got Parse function

BUG=webrtc:5260
R=åsapersson

Committed: https://crrev.com/de13882d9471bf18709e52fa9a9eac1378b359be
Cr-Commit-Position: refs/heads/master@{#11428}
==========

[commit-bot: I haz the power, 2016-01-29 19:26:28]

Patchset 7 (id:??) landed as
https://crrev.com/de13882d9471bf18709e52fa9a9eac1378b359be
Cr-Commit-Position: refs/heads/master@{#11428}