Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(549)

Unified Diff: webrtc/base/network.cc

Issue 1556743002: Bind a socket to a network if the network handle is set. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Fix a compiling issue for Windows Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/base/network.cc
diff --git a/webrtc/base/network.cc b/webrtc/base/network.cc
index 488c475137a2ee8d7ddbea1fa2ace59175cc3f36..6d0f2de9b882c190cc30c1dfebf617774883ece5 100644
--- a/webrtc/base/network.cc
+++ b/webrtc/base/network.cc
@@ -731,7 +731,7 @@ void BasicNetworkManager::StartNetworkMonitor() {
if (factory == nullptr) {
return;
}
- network_monitor_.reset(factory->CreateNetworkMonitor());
+ network_monitor_ = factory->GetOrCreateNetworkMonitor();
pthatcher1 2016/01/14 20:07:24 Why is it necessary for the factory to own the net
honghaiz3 2016/01/15 01:00:38 It is a good point. I revised it to own the monito
if (!network_monitor_) {
return;
}
@@ -745,7 +745,6 @@ void BasicNetworkManager::StopNetworkMonitor() {
return;
}
network_monitor_->Stop();
- network_monitor_.reset();
}
void BasicNetworkManager::OnMessage(Message* msg) {

Powered by Google App Engine
This is Rietveld 408576698