Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1556703002: Remove always-on options in OveruseFrameDetector. (Closed)

Created:
4 years, 11 months ago by pbos-webrtc
Modified:
4 years, 11 months ago
Reviewers:
åsapersson
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, andresp, the sun, perkj_webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove always-on options in OveruseFrameDetector. BUG=webrtc:5132 R=asapersson@webrtc.org Committed: https://crrev.com/01f364ef06cc8b1e7c64cc8038d6cb0e872384f3 Cr-Commit-Position: refs/heads/master@{#11169}

Patch Set 1 #

Total comments: 2

Patch Set 2 : remove redundant methods #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -122 lines) Patch
M webrtc/video/overuse_frame_detector.h View 2 chunks +1 line, -12 lines 0 comments Download
M webrtc/video/overuse_frame_detector.cc View 3 chunks +5 lines, -26 lines 0 comments Download
M webrtc/video/overuse_frame_detector_unittest.cc View 1 15 chunks +0 lines, -83 lines 0 comments Download
M webrtc/video/video_capture_input.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
pbos-webrtc
PTAL
4 years, 11 months ago (2015-12-30 20:08:18 UTC) #1
åsapersson
lgtm https://codereview.webrtc.org/1556703002/diff/1/webrtc/video/overuse_frame_detector_unittest.cc File webrtc/video/overuse_frame_detector_unittest.cc (right): https://codereview.webrtc.org/1556703002/diff/1/webrtc/video/overuse_frame_detector_unittest.cc#newcode310 webrtc/video/overuse_frame_detector_unittest.cc:310: // UsagePercent() > high_encode_usage_threshold_percent => overuse. These two ...
4 years, 11 months ago (2016-01-07 15:02:46 UTC) #2
pbos-webrtc
remove redundant methods
4 years, 11 months ago (2016-01-07 15:36:31 UTC) #3
pbos-webrtc
https://codereview.webrtc.org/1556703002/diff/1/webrtc/video/overuse_frame_detector_unittest.cc File webrtc/video/overuse_frame_detector_unittest.cc (right): https://codereview.webrtc.org/1556703002/diff/1/webrtc/video/overuse_frame_detector_unittest.cc#newcode310 webrtc/video/overuse_frame_detector_unittest.cc:310: // UsagePercent() > high_encode_usage_threshold_percent => overuse. On 2016/01/07 15:02:46, ...
4 years, 11 months ago (2016-01-07 15:36:36 UTC) #4
pbos-webrtc
Committed patchset #2 (id:20001) manually as 01f364ef06cc8b1e7c64cc8038d6cb0e872384f3 (presubmit successful).
4 years, 11 months ago (2016-01-07 15:38:37 UTC) #7
commit-bot: I haz the power
4 years, 11 months ago (2016-01-07 15:38:41 UTC) #9
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/01f364ef06cc8b1e7c64cc8038d6cb0e872384f3
Cr-Commit-Position: refs/heads/master@{#11169}

Powered by Google App Engine
This is Rietveld 408576698